Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple typos of different importance #102

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/latest.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ async function main() {
* The problem with the prerelease is that if the test runs for both the stable and the prerelease,
* and the prerelease has a breaking change, then the stable will fail.
*
* If we update the the starter to match the prerelease, then the stable will fail.
* If we update the starter to match the prerelease, then the stable will fail.
*
* This means that if there is a breaking change in a prerelease, we will ALWAYS get a warning 😄, which defeats the purpose.
*
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vite_hardhat_nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
with:
payload: |
{
"text": "Oooops, seems like latest stable Noir breaks noir-starter! Projects needing updating: vite-hardhat ${{ matrix.version }}"
"text": "Oooops, seems like the latest stable Noir breaks noir-starter! Projects needing updating: vite-hardhat ${{ matrix.version }}"
}
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
Expand Down
8 changes: 4 additions & 4 deletions with-foundry/lib/forge-std/src/StdUtils.sol
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,13 @@ abstract contract StdUtils {
}

/// @dev returns the hash of the init code (creation code + no args) used in CREATE2 with no constructor arguments
/// @param creationCode the creation code of a contract C, as returned by type(C).creationCode
/// @param creationCode is the creation code of a contract C, as returned by type(C).creationCode
function hashInitCode(bytes memory creationCode) internal pure returns (bytes32) {
return hashInitCode(creationCode, "");
}

/// @dev returns the hash of the init code (creation code + ABI-encoded args) used in CREATE2
/// @param creationCode the creation code of a contract C, as returned by type(C).creationCode
/// @param creationCode is the creation code of a contract C, as returned by type(C).creationCode
/// @param args the ABI-encoded arguments to the constructor of C
function hashInitCode(bytes memory creationCode, bytes memory args) internal pure returns (bytes32) {
return keccak256(abi.encodePacked(creationCode, args));
Expand Down Expand Up @@ -163,7 +163,7 @@ abstract contract StdUtils {
// Make the aggregate call.
(, bytes[] memory returnData) = multicall.aggregate(calls);

// ABI decode the return data and return the balances.
// ABI decodes the return data and returns the balances.
balances = new uint256[](length);
for (uint256 i = 0; i < length; ++i) {
balances[i] = abi.decode(returnData[i], (uint256));
Expand All @@ -178,7 +178,7 @@ abstract contract StdUtils {
return address(uint160(uint256(bytesValue)));
}

// Used to prevent the compilation of console, which shortens the compilation time when console is not used elsewhere.
// Used to prevent the compilation of the console, which shortens the compilation time when the console is not used elsewhere.

function console2_log(string memory p0, uint256 p1) private view {
(bool status,) = address(CONSOLE2_ADDRESS).staticcall(abi.encodeWithSignature("log(string,uint256)", p0, p1));
Expand Down
18 changes: 9 additions & 9 deletions with-foundry/lib/forge-std/src/Vm.sol
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ interface VmSafe {
// Writes line to file, creating a file if it does not exist.
// `path` is relative to the project root.
function writeLine(string calldata path, string calldata data) external;
// Closes file for reading, resetting the offset and allowing to read it from beginning with readLine.
// Closes file for reading, resetting the offset and allowing to read it from the beginning with readLine.
// `path` is relative to the project root.
function closeFile(string calldata path) external;
// Removes a file from the filesystem.
Expand Down Expand Up @@ -199,9 +199,9 @@ interface VmSafe {
function recordLogs() external;
// Gets all the recorded logs
function getRecordedLogs() external returns (Log[] memory logs);
// Derive a private key from a provided mnenomic string (or mnenomic file path) at the derivation path m/44'/60'/0'/0/{index}
// Derive a private key from a provided mnemonic string (or mnemonic file path) at the derivation path m/44'/60'/0'/0/{index}
function deriveKey(string calldata mnemonic, uint32 index) external pure returns (uint256 privateKey);
// Derive a private key from a provided mnenomic string (or mnenomic file path) at {derivationPath}{index}
// Derive a private key from a provided mnemonic string (or mnemonic file path) at {derivationPath}{index}
function deriveKey(string calldata mnemonic, string calldata derivationPath, uint32 index)
external
pure
Expand Down Expand Up @@ -380,14 +380,14 @@ interface Vm is VmSafe {
// Prepare an expected log with all four checks enabled.
// Call this function, then emit an event, then call a function. Internally after the call, we check if
// logs were emitted in the expected order with the expected topics and data.
// Second form also checks supplied address against emitting contract.
// Second form also checks the supplied address against the emitting contract.
function expectEmit() external;
function expectEmit(address emitter) external;

// Prepare an expected log with (bool checkTopic1, bool checkTopic2, bool checkTopic3, bool checkData).
// Call this function, then emit an event, then call a function. Internally after the call, we check if
// logs were emitted in the expected order with the expected topics and data (as specified by the booleans).
// Second form also checks supplied address against emitting contract.
// Second form also checks the supplied address against the emitting contract.
function expectEmit(bool checkTopic1, bool checkTopic2, bool checkTopic3, bool checkData) external;
function expectEmit(bool checkTopic1, bool checkTopic2, bool checkTopic3, bool checkData, address emitter)
external;
Expand Down Expand Up @@ -446,12 +446,12 @@ interface Vm is VmSafe {
function createFork(string calldata urlOrAlias, uint256 blockNumber) external returns (uint256 forkId);
// Creates a new fork with the given endpoint and the _latest_ block and returns the identifier of the fork
function createFork(string calldata urlOrAlias) external returns (uint256 forkId);
// Creates a new fork with the given endpoint and at the block the given transaction was mined in, replays all transaction mined in the block before the transaction,
// Creates a new fork with the given endpoint and at the block the given transaction was mined in, replays all transactions mined in the block before the transaction,
// and returns the identifier of the fork
function createFork(string calldata urlOrAlias, bytes32 txHash) external returns (uint256 forkId);
// Creates _and_ also selects a new fork with the given endpoint and block and returns the identifier of the fork
function createSelectFork(string calldata urlOrAlias, uint256 blockNumber) external returns (uint256 forkId);
// Creates _and_ also selects new fork with the given endpoint and at the block the given transaction was mined in, replays all transaction mined in the block before
// Creates _and_ also selects new fork with the given endpoint and at the block the given transaction was mined in, replays all transactions mined in the block before
// the transaction, returns the identifier of the fork
function createSelectFork(string calldata urlOrAlias, bytes32 txHash) external returns (uint256 forkId);
// Creates _and_ also selects a new fork with the given endpoint and the latest block and returns the identifier of the fork
Expand All @@ -464,11 +464,11 @@ interface Vm is VmSafe {
// This is similar to `roll` but for the currently active fork
function rollFork(uint256 blockNumber) external;
// Updates the currently active fork to given transaction
// this will `rollFork` with the number of the block the transaction was mined in and replays all transaction mined before it in the block
// this will `rollFork` with the number of the block the transaction was mined in and replays all transactions mined before it in the block
function rollFork(bytes32 txHash) external;
// Updates the given fork to given block number
function rollFork(uint256 forkId, uint256 blockNumber) external;
// Updates the given fork to block number of the given transaction and replays all transaction mined before it in the block
// Updates the given fork to block number of the given transaction and replays all transactions mined before it in the block
function rollFork(uint256 forkId, bytes32 txHash) external;
// Marks that the account(s) should use persistent storage across fork swaps in a multifork setup
// Meaning, changes made to the state of this account will be kept when switching forks
Expand Down