Skip to content

Azd up resilience #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Azd up resilience #9

wants to merge 3 commits into from

Conversation

ams0
Copy link

@ams0 ams0 commented Jun 18, 2025

Purpose

Improve instructions for deploying in your own environment

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@ams0 ams0 requested review from hdmeyer, JoranBergfeld and Copilot and removed request for hdmeyer and JoranBergfeld June 24, 2025 12:44
Copilot

This comment was marked as outdated.

@ams0 ams0 requested a review from Copilot June 24, 2025 12:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances deployment flexibility by introducing a configurable Azure region and adding step-by-step instructions for using azd.

  • Add a location parameter to the ARM parameters file and expose it via an environment variable.
  • Replace the hard-coded region in the Bicep template with the new location parameter.
  • Expand the README with a “Deployment Instructions” section showing how to set up and run the infrastructure.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
infra/main.parameters.json Added "location" parameter to pick up ${AZURE_LOCATION}
infra/main.bicep Defined a location param and replaced the hard-coded region
infra/README.md Added detailed deployment steps and env-var instructions
Comments suppressed due to low confidence (3)

infra/README.md:58

  • [nitpick] The fenced code block marker has no indent, but the inner lines are indented; to ensure consistent rendering, align the backticks and the code lines with the list indentation.
```bash

infra/main.parameters.json:16

  • [nitpick] Indentation of the newly added lines for the location parameter (the closing brace and the "location" key) does not match the existing properties; align them with the surrounding entries.
        },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant