Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update of AI-GPT tagging #669

Merged
merged 1 commit into from
Feb 27, 2025
Merged

feat: update of AI-GPT tagging #669

merged 1 commit into from
Feb 27, 2025

Conversation

davenewman777
Copy link
Contributor

Overview/Summary

Rework of AI tagging based on conversation with Eric and Kyle

  • [x ] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [x ] Checked for duplicate Pull Requests
  • [x ] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [x ] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [x ] Ensured PR tests are passing
  • [x ] Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • [x ] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings February 26, 2025 19:19
@davenewman777 davenewman777 requested review from a team as code owners February 26, 2025 19:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (12)

azure-specialized-workloads/ai/recommendations.yaml:47

  • This file now adds the AI-GPT-RAG tag while other recommendation files remove it; please review if the tagging strategy is intended to differ here.
tags: [AI-GPT-RAG]

azure-resources/Network/bastionHosts/recommendations.yaml:13

  • The removal of the AI-GPT-RAG tag here contrasts with its addition in the AI recommendations file; consider aligning the tagging strategy across similar resources.
tags: []

azure-resources/Batch/batchAccounts/recommendations.yaml:13

  • Removing the AI-GPT-RAG tag here may create inconsistency with the overall tagging approach; please verify that this change is intentional.
tags: []

azure-resources/Batch/batchAccounts/recommendations.yaml:30

  • The change removes the AI-GPT-RAG tag; ensure that this aligns with the unified tagging strategy across all similar recommendation files.
tags: []

azure-resources/CognitiveServices/accounts/recommendations.yaml:64

  • Consider reviewing the removal of the AI-GPT-RAG tag here to ensure consistency with the expected tag usage in related recommendation files.
tags: []

azure-resources/CognitiveServices/accounts/recommendations.yaml:81

  • The removal of the AI-GPT-RAG tag might lead to inconsistency; please confirm that this change reflects the intended tagging approach.
tags: []

azure-resources/CognitiveServices/accounts/recommendations.yaml:98

  • Ensure that the removal of the AI-GPT-RAG tag is consistent with the overall tagging strategy across all recommendation configurations.
tags: []

azure-resources/MachineLearningServices/registries/recommendations.yaml:13

  • Please confirm that removing the AI-GPT-RAG tag here aligns with the intended unified tagging strategy across similar resource recommendations.
tags: []

azure-resources/ApiManagement/service/recommendations.yaml:81

  • The removal of the AI-GPT-RAG tag in this configuration should be re-evaluated for consistency with other service recommendations.
tags: []

azure-resources/MachineLearningServices/workspaces/recommendations.yaml:13

  • Verify that the removal of the AI-GPT-RAG tag is intentional and consistent with the tagging practices applied in other similar recommendation files.
tags: []

azure-resources/MachineLearningServices/workspaces/recommendations.yaml:30

  • Ensure that the removal of the AI-GPT-RAG tag is consistent here with the overall resource tagging strategy used across recommendations.
tags: []

azure-resources/MachineLearningServices/workspaces/recommendations.yaml:47

  • The removal of the AI-GPT-RAG tag at this location should be double-checked against the tagging strategy, ensuring consistency with other changes.
tags: []
@davenewman777 davenewman777 changed the title Main update of AI-GPT tagging Feb 26, 2025
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry changed the title update of AI-GPT tagging feat: update of AI-GPT tagging Feb 27, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Feb 27, 2025
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry merged commit 83d4cb5 into Azure:main Feb 27, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants