Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct config usage for generate-test-project and generate-sample-project #5188

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

welovej
Copy link
Member

@welovej welovej commented Nov 29, 2024

Description

config: generate-test-project's default value is false, but generate-sample-project's default value is true. Before this PR, If both used default value, judegment about generate-test-project is actually depend on generate-sample-project.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@live1206
Copy link
Member

live1206 commented Dec 2, 2024

config: generate-test-project's default value is false, but generate-sample-project's default value is true. Before this PR, If both used default value, judegment about generate-test-project is actually depend on generate-sample-project.

Should generate-test-project be default as true as well? Before this PR, the current behavior of generate-test-project is default as true.

Copy link
Member

@pshao25 pshao25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it is correct behavior. It changes DPG's behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants