{Misc} Remove various Python 2.7 ImportError #30451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atombrella
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
yanzhudd,
digimaun,
kairu-ms,
necusjz,
calvinhzy,
jiasli,
evelyn-ys and
bebound
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
microsoft-github-policy-service
bot
added
the
customer-reported
jiasli
reviewed
Dec 4, 2024
| except ImportError: | ||
| # deprecated and redirected to decodebytes in Python 3 | ||
| from base64 import decodestring as base64_decode | ||
| from base64 import decodebytes as base64_decode |
There was a problem hiding this comment.
Per https://docs.python.org/3/library/base64.html#base64.decodebytes, base64.decodebytes is actually a legacy interface. I will fix it in another PR.
jiasli
approved these changes
Dec 4, 2024
bebound
approved these changes
Dec 4, 2024
wangzelin007
approved these changes
Dec 4, 2024
evelyn-ys
approved these changes
Dec 4, 2024
zhoxing-ms
approved these changes
Dec 4, 2024
jsntcy
approved these changes
Dec 4, 2024
jiasli
reviewed
Dec 4, 2024
|
|
||
| from azure.cli.telemetry.components.telemetry_client import (CliTelemetryClient, _NoRetrySender, http_client_t) |
There was a problem hiding this comment.
http_client_t is a confusing name. @evelyn-ys
|
@atombrella, Thank you very much for the contribution! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taken from #30368
Remove the various Python 2.7 import fallbacks. This was mostly limited to
urllib.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.