{dls} Upgrade azure-datalake-store to 1.0.0a0 #30770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
jiasli
reviewed
Feb 6, 2025
| @@ -26,12 +26,8 @@ def cf_dls_filesystem(cli_ctx, account_name): | |||
| from azure.datalake.store import core | |||
| from azure.cli.core._profile import Profile | |||
|
|
|||
| profile = Profile(cli_ctx=cli_ctx) | |||
| subscription_id = None | |||
There was a problem hiding this comment.
It is weird subscription_id is set to None and then passed to get_login_credentials().
jiasli
approved these changes
Feb 6, 2025
akharit
approved these changes
Feb 6, 2025
jsntcy
approved these changes
Feb 7, 2025
yonzhan
approved these changes
Feb 7, 2025
jiasli
reviewed
Feb 7, 2025
| cred, subscription_id, _ = profile.get_login_credentials( | ||
| subscription_id=subscription_id, | ||
| resource=cli_ctx.cloud.endpoints.active_directory_data_lake_resource_id) | ||
| cred, _, _ = Profile(cli_ctx=cli_ctx).get_login_credentials() |
There was a problem hiding this comment.
Please double check if cli_ctx.cloud.endpoints.active_directory_data_lake_resource_id needs to be set as credential_scopes when creating AzureDLFileSystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Upgrade
azure-datalake-storeSDK to1.0.0a0. As listed in SDK release historyThis will unblock us from dropping
signed_session()interface in #29631Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.