Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] az aks nodepool upgrade: Fix --node-soak-duration cannot be set to 0 #30778

Merged
merged 1 commit into from
Feb 7, 2025
Merged

[AKS] az aks nodepool upgrade: Fix --node-soak-duration cannot be set to 0 #30778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/acs/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2570,7 +2570,7 @@ def aks_agentpool_upgrade(cmd, client, resource_group_name, cluster_name,
instance.upgrade_settings.max_surge = max_surge
if drain_timeout:
instance.upgrade_settings.drain_timeout_in_minutes = drain_timeout
if node_soak_duration:
if isinstance(node_soak_duration, int) and node_soak_duration >= 0:
instance.upgrade_settings.node_soak_duration_in_minutes = node_soak_duration

# custom headers
Expand Down