{Batch} Set credential_scopes when creating BatchClient
#30785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
jiasli
force-pushed
the
batch-credential-scopes
branch
from
e3edb2a to
f14133a
Compare
jiasli
commented
Feb 7, 2025
| @@ -332,8 +332,7 @@ def validate_client_parameters(cmd, namespace): | |||
| # check to see if we are using the default credentials | |||
| from azure.cli.core._profile import Profile | |||
| profile = Profile(cli_ctx=cmd.cli_ctx) | |||
| resource = cmd.cli_ctx.cloud.endpoints.batch_resource_id | |||
| token_credential, _, _ = profile.get_login_credentials(resource=resource) | |||
| token_credential, _, _ = profile.get_login_credentials() | |||
There was a problem hiding this comment.
token_credential is not actually used to create a client, so specifying the resource is unnecessary.
jiasli
force-pushed
the
batch-credential-scopes
branch
from
f14133a to
2015434
Compare
evelyn-ys
approved these changes
Feb 8, 2025
wiboris
approved these changes
Feb 8, 2025
wiboris
approved these changes
Feb 11, 2025
zhoxing-ms
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az batchDescription
The Track 2 migration for
azure-batchSDK (#30501) is incomplete - it doesn't setcredential_scopeswhen creatingBatchClient.This will cause failure in sovereign clouds as different clouds have different
batch_resource_id:azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 365 in 5814523
azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 402 in 5814523
azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 433 in 5814523
azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 465 in 5814523