{Synapse} Set credential_scopes when creating clients
#30788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
jiasli
changed the title
credential_scopes when creating clientscredential_scopes when creating clients
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yonzhan,
jsntcy and
evelyn-ys
jiasli
commented
Feb 7, 2025
| return SparkClient( | ||
| credential=cred, | ||
| endpoint='{}{}{}'.format("https://", workspace_name, cli_ctx.cloud.suffixes.synapse_analytics_endpoint), | ||
| spark_pool_name=sparkpool_name | ||
| spark_pool_name=sparkpool_name, | ||
| credential_scopes=resource_to_scopes(cli_ctx.cloud.endpoints.synapse_analytics_resource_id) |
There was a problem hiding this comment.
SparkClient's handling of credential_scopes is wrong.
In azure.synapse.spark._configuration.SparkClientConfiguration.__init__
self.credential_scopes = ['https://dev.azuresynapse.net/.default']
self.credential_scopes.extend(kwargs.pop('credential_scopes', []))credential_scopes is added to the existing ['https://dev.azuresynapse.net/.default'], instead of replacing it. See Azure/autorest.python#745.
#29690 dropped support for this incorrect usage.
AccessControlClient, ArtifactsClient, VnetClient are correct.
jiasli
force-pushed
the
synapse-credential-scopes
branch
from
dffed0c to
8b9e3c2
Compare
jiasli
force-pushed
the
synapse-credential-scopes
branch
from
8b9e3c2 to
9f8a5a8
Compare
evelyn-ys
approved these changes
Feb 13, 2025
wanyang7
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
credential_scopesis not set when creatingazure.synapseclients.This will cause failure in sovereign clouds as different clouds have different
synapse_analytics_resource_id:azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 378 in 5814523
azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 414 in 5814523
azure-cli/src/azure-cli-core/azure/cli/core/cloud.py
Line 445 in 5814523