[App Service] az functionapp create: Refactor EOL message
#30791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
kamperiadis
requested review from
jsntcy,
zhoxing-ms and
yanzhudd
as code owners
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
yanzhudd
changed the title
az functionapp create: Refactor eol messageaz functionapp create: Refactor EOL message
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
reviewed
Feb 8, 2025
| from dateutil.relativedelta import relativedelta | ||
| # we would not be able to validate for a custom runtime | ||
| if runtime == 'custom': | ||
| return | ||
|
|
||
| today = datetime.datetime.now(datetime.timezone.utc) | ||
| six_months = today + relativedelta(months=+6) | ||
| runtimes = [r for r in self.stacks if runtime == r.name] | ||
| runtimes = [r for r in self.stacks if r.linux == linux and runtime == r.name] |
There was a problem hiding this comment.
r.linux == linux
This code looks a bit confusing, could you please improve its readability?
yanzhudd
changed the title
az functionapp create: Refactor EOL messageaz functionapp create: Refactor EOL message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp createDescription
We are modifying the messaging shown for the end of life runtimes
Testing Guide
az functionapp create ... --runtime powershell --runtime-version 7.2--> shows ValidationError messageaz functionapp create ... --runtime node --runtime-version 18--> shows warning messageThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.