{Packaging} Remove empty __pycache__ folder in zip package
#30818
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007,
yonzhan and
jsntcy
bebound
commented
Feb 13, 2025
| @@ -207,7 +207,7 @@ popd | |||
|
|
|||
| REM Remove __pycache__ | |||
| echo remove pycache | |||
| for /d /r %BUILDING_DIR%\Lib\site-packages\pip %%d in (__pycache__) do ( | |||
| for /d /r %BUILDING_DIR%\Lib\site-packages\ %%d in (__pycache__) do ( | |||
There was a problem hiding this comment.
Pip pyc files are deleted in #6625.
Calling pip is slightly slower because it compiles byte code on the fly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are 2072 empty
__pycache__folders in 2.69.0 zip package. For example:Lib/site-packages/__pycache__.In
build.cmd, we only remove__pycache__files inpipfolder. The empty__pycache__folders are never been removed. Since msi package ingores emtpy folder by default, this issue does not happen in msi.Testing Guide