Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error if hns network exists for transparent network #2877

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

paulyufan2
Copy link
Contributor

Reason for Change:

The PR is to not ignore network exist if network type is transparent to avoid creating a second endpoint

Issue Fixed:

Requirements:

Notes:

@paulyufan2 paulyufan2 added the cni Related to CNI. label Jul 24, 2024
@paulyufan2 paulyufan2 requested a review from tamilmani1989 July 24, 2024 20:36
@paulyufan2 paulyufan2 requested a review from a team as a code owner July 24, 2024 20:36
@paulyufan2 paulyufan2 force-pushed the transparentNetworkReturnError branch 2 times, most recently from 1916fa9 to 6270e61 Compare July 24, 2024 22:04
network/network_windows.go Outdated Show resolved Hide resolved
network/network_windows.go Outdated Show resolved Hide resolved
@paulyufan2 paulyufan2 force-pushed the transparentNetworkReturnError branch from 9b63de9 to 3d3ba0a Compare July 25, 2024 00:17
@paulyufan2 paulyufan2 enabled auto-merge July 25, 2024 00:19
@tamilmani1989 tamilmani1989 changed the title Do not ignore network exist if network type is transparent Return error if hns network exists for transparent network Jul 25, 2024
@paulyufan2 paulyufan2 force-pushed the transparentNetworkReturnError branch from 3d3ba0a to d5b073d Compare July 25, 2024 18:32
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 added this pull request to the merge queue Jul 25, 2024
@paulyufan2 paulyufan2 removed this pull request from the merge queue due to a manual request Jul 25, 2024
@paulyufan2 paulyufan2 force-pushed the transparentNetworkReturnError branch from d5b073d to 7e826f6 Compare July 25, 2024 20:18
@paulyufan2
Copy link
Contributor Author

/azp run Azure Container Networking PR

@paulyufan2 paulyufan2 enabled auto-merge July 25, 2024 21:34
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 added this pull request to the merge queue Jul 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@paulyufan2 paulyufan2 added this pull request to the merge queue Jul 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@paulyufan2 paulyufan2 added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit c9b99ed Jul 26, 2024
11 checks passed
@paulyufan2 paulyufan2 deleted the transparentNetworkReturnError branch July 26, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cni Related to CNI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants