-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azd env set
un-escapes special characters in values
#4542
base: main
Are you sure you want to change the base?
Conversation
@@ -281,10 +286,42 @@ func fixupUnquotedDotenv(values map[string]string, dotenv string) string { | |||
// Instead of calling `godotenv.Write` directly, we need to save the file ourselves, so we can fixup any numeric values | |||
// that were incorrectly unquoted. | |||
func marshallDotEnv(env *Environment) (string, error) { | |||
marshalled, err := godotenv.Marshal(env.dotenv) | |||
marshalled, err := Marshal(env.dotenv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests to verify this functionality to check for well known uses cases as well as cases that fall into this special treatment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbreza Unit tests have been added, please check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbreza We have updated by your comments, please re-review. Thanks.
0f3c2fc
to
276471d
Compare
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Fixes issue#511.
azd env set
un-escapes special characters in the value, such as "!", "$", "`".@rajeshkamal5050 for notification.