Update the default azd metadata field's type to any
#5384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Menghua1
requested review from
wbreza,
vhvb1989,
hemarina,
weikanglim,
JeffreyCA and
rajeshkamal5050
as code owners
1 task
There was a problem hiding this comment.
LGTM - @vhvb1989, will adding this flexibility cause any unintended issues elsewhere?
|
FYI @alexwolfmsft for updating the docs |
JeffreyCA
reviewed
Jun 20, 2025
Comment on lines
382
to
395
| defaultBool := true | ||
| if azdMetadata.Default != nil { | ||
| switch v := azdMetadata.Default.(type) { | ||
| case bool: | ||
| defaultBool = v | ||
| case string: | ||
| defaultBool = strings.EqualFold(v, "true") | ||
| default: | ||
| strVal := fmt.Sprintf("%v", v) | ||
| defaultBool = strings.EqualFold(strVal, "true") | ||
| } | ||
| } | ||
| msg := fmt.Sprintf("Would you like to set the '%s' infrastructure %s to %t?", key, securedParam, defaultBool) | ||
| confirmValue, err := p.console.Confirm(ctx, input.ConsoleOptions{ | ||
| Message: msg, | ||
| Help: help, | ||
| Options: options, | ||
| DefaultValue: defaultValueForPrompt, | ||
| DefaultValue: true, | ||
| }) |
There was a problem hiding this comment.
I feel like the new prompt change could get a bit confusing, especially if the Bicep param has a default of false because of the double negative.
Bicep:
@metadata({azd: {
default: false
}})
param param1 boolNew prompt: if the user inputs 'n', then the value becomes true in this case:
Old prompt, a bit more explicit:
@SophCarp would love to get your thoughts here as well 🙂
There was a problem hiding this comment.
I prefer the way of selection (y/n) in the new prompt, but it does feel confusing due to double negative. Could we ask if users would like to set 'paraml' to true (y/N)?
There was a problem hiding this comment.
hmmm. By default, param1 would be false. y/n isn't the same as true/false, but rather "confirm/change". "default" should be included in the question, because otherwise a customer might be confused why they're being asked a double negative question.
Maybe :
? 'param1's default value is false. Keep default value? y/nor:
? Infrastructure parameter 'param1' has a default value of 'false'. Keep default value?
> Keep (param1=false)
Change (param1=true) or:
? Confirm infrastructure parameter 'param1' = false:
> Yes (param1=false)
No (param1=true)or:
? Confirm infrastructure parameter 'param1' = false: y/n
Is there more direct wording than "infrastructure parameter"? This is different from "environment variable", right?
|
used #5386 to fix the prompt regressions on bool/int with no defaults. @Menghua1 , let's use this PR for only adding support for types in the default azd metadata field.
Instead of the current:
Similar for |
Remove temporary variables Co-authored-by: JeffreyCA <[email protected]>
Menghua1
changed the title
bool default in AzdMetadata and use Confirmation for boolean parametersdefault azd metadata field's type to any
|
@vhvb1989 Got it. The code has been updated to only add support for types in the default azd metadata field. |
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
AzdMetadata.Defaultfield type toanyto support default values of typeboolandint.For
boolparameters: TheAzdMetadata.Defaultfield must be of typebool.Other types are not supported and will result in an error as follow:
For
intparameters: TheAzdMetadata.Defaultfield must be of typeint.Other types are not supported and will result in an error as follow:
@rajeshkamal5050 and @vhvb1989 for notification.