Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .net9 sdk #10635

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Update to .net9 sdk #10635

wants to merge 3 commits into from

Conversation

jviau
Copy link
Contributor

@jviau jviau commented Nov 14, 2024

DO NOT MERGE YET

The SDK change has a tangible impact to our artifacts. With 8.0.101 SDK we have some OOB packages pinned ahead of the runtime, which leads to those assemblies being explicitly included (example: System.Text.Json). When updating the SDK, the runtime is now ahead or same version as our package ref's and they are then excluded from our outputs. This will have a downstream impact if the hosted environments do not have a new enough runtime to match our requested OOB packages. We should first verify Antares and linux images have the latest .net8 runtime installed before merging this PR.

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR -- TODO
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Updates to .net9 SDK which addresses a restore issue with r2r.

deps.json changes:

Previous file: C:\repos\func\host-2\out\bin\WebJobs.Script.Tests\debug\Microsoft.Azure.WebJobs.Script.WebHost.deps.json
New file:      C:\repos\func\host-2\out\bin\WebJobs.Script.WebHost\debug\Microsoft.Azure.WebJobs.Script.WebHost.deps.json

  Changed:

  Removed:
    - System.Text.Json.dll: 8.0.0.0/8.0.1024.46610

  Added:

@jviau jviau requested a review from a team as a code owner November 14, 2024 17:51
@jviau jviau requested a review from fabiocav November 14, 2024 17:51
fabiocav
fabiocav previously approved these changes Nov 14, 2024
@fabiocav fabiocav self-requested a review November 14, 2024 19:37
@fabiocav fabiocav dismissed their stale review November 14, 2024 19:38

Additional questions

@fabiocav
Copy link
Member

The removal flagged seems like a bug with the validation.

It's actually possible this will differ in other environments.

@fabiocav
Copy link
Member

fabiocav commented Nov 14, 2024

Removed approval while we discuss potential problems with the change.

Capturing: We cannot bump 8.x ahead of the managed environments as this wouldn't be safe (that change is what leads to the STJ difference flagged above). The 9.x dependency is fine now, but the same applies with future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants