-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[in-proc backport] Replace build-extension.ps1 with SiteExtension.csproj #10649
base: in-proc
Are you sure you want to change the base?
Conversation
Dependency ReviewThe following issues were found:
Vulnerabilitiessrc/WebJobs.Script.WebHost/WebJobs.Script.WebHost.csproj
OpenSSF Scorecard
Scanned Files
|
@@ -499,6 +499,4 @@ local.settings.json | |||
/tools/ExtensionsMetadataGenerator/test/ExtensionsMetadataGeneratorTests/runtimeAssemblies.txt | |||
|
|||
local.settings.json | |||
msbuild.binlog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are already in gitignore
Current blocker for this PR: Part of this change was to leverage msbuild project dependencies to build in parallel and avoid double-building when we publish the separate net6 and net8 site extensions. A result of this is changing how the version property resolves: using TFM instead of a supplied parameter. This has led to an issue: Fix options:
I will go with option 2 for now, then follow up on option 1 in another PR. |
Issue describing the changes in this PR
This is the in-proc backport for #10168
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Replaces
build-extension.ps1
with an msbuild project to build our site extension for net6.0 and net8.0 simultaneously.