Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing SWT authentication handler #10654

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Removing SWT authentication handler #10654

merged 1 commit into from
Dec 3, 2024

Conversation

mathewc
Copy link
Member

@mathewc mathewc commented Nov 25, 2024

Earlier in the year, I had already deactivated the SWT authentication handler (in this PR). Those changes have been fully released.

In this PR I'm just cleaning this dead code up now - removing the auth handler and supporting code. This handles incoming SWTs (no longer supported). I'll handle outbound SWTs in an upcoming PR. There are only 2 outbound calls SWTs are included on, and those can be controlled via hosting config. So for that, we'll do hosting config testing first, then follow up with code removal.

I will be backporting this to the in-proc branch, but no further.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@mathewc mathewc requested a review from a team as a code owner November 25, 2024 23:31
@mathewc mathewc requested a review from fabiocav November 27, 2024 17:14
@mathewc mathewc merged commit ce931ee into dev Dec 3, 2024
11 checks passed
@mathewc mathewc deleted the swt-auth-cleanup branch December 3, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants