Added CodeQL suppression justification comments for HTTP response building code path #10657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e handling code path.
jviau
approved these changes
Nov 27, 2024
|
Thanks Shyju. We need approval from Anirudh on similar PRs. Example PR with his approval and comment - Azure/azure-functions-dotnet-worker#2811 (review). Please also share codeql guidance link along with your PR. We can also update the title of PR similar to the one I linked here or this - link. |
| @@ -79,10 +79,12 @@ public async Task ExecuteResultAsync(ActionContext context) | |||
| { | |||
| if (cookie.Item3 != null) | |||
| { | |||
| // CodeQL [SM02373] This code path constructs the cookie collection based on what the out-of-process function app (where customers can set these cookies) sends to the host. Marking these cookies as "Secure" would introduce a breaking change for those customers. | |||
There was a problem hiding this comment.
We can probably replace Marking these cookies as "Secure" with Overriding this behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CodeQL suppression justification comments for out of process layer response handling code path.
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md