Adding resiliency model as an optional parameter on virtual network gateway for ExpressRoute #26485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Batch
️✔️Az.CognitiveServices
️✔️Az.Compute
️✔️Az.ContainerRegistry
️✔️Az.CosmosDB
️✔️Az.DataLakeStore
️✔️Az.Dns
️✔️Az.EventHub
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️ Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 77.92 % 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 77.92% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 77.92% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 77.92% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzVirtualNetworkGateway 2 5 Unassigned_Variable New-AzVirtualNetwork -Subnet $subnet is a null-valued parameter value. -Subnet Assign value for $subnet. ⚠️ New-AzVirtualNetworkGateway 3 8 Unassigned_Variable New-AzVpnClientRootCertificate -Name $clientRootCertName is a null-valued parameter value. -Name Assign value for $clientRootCertName. ⚠️ New-AzVirtualNetworkGateway 3 8 Unassigned_Variable New-AzVpnClientRootCertificate -PublicCertData $samplePublicCertData is a null-valued parameter value. -PublicCertData Assign value for $samplePublicCertData. ⚠️ New-AzVirtualNetworkGateway 4 5 Unassigned_Variable New-AzVirtualNetwork -Subnet $subnet is a null-valued parameter value. -Subnet Assign value for $subnet. ⚠️ Set-AzVirtualNetworkGateway 7 5 Mismatched_Parameter_Value_Type Set-AzVirtualNetworkGateway -NatRule $vngNatRules.NatRules is not an expected parameter value type. -NatRule Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetworkGatewayNatRule. Now the type is .(Command).
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzVirtualNetworkGateway 2 5 Unassigned_Variable New-AzVirtualNetwork -Subnet $subnet is a null-valued parameter value. -Subnet Assign value for $subnet. ⚠️ New-AzVirtualNetworkGateway 3 8 Unassigned_Variable New-AzVpnClientRootCertificate -Name $clientRootCertName is a null-valued parameter value. -Name Assign value for $clientRootCertName. ⚠️ New-AzVirtualNetworkGateway 3 8 Unassigned_Variable New-AzVpnClientRootCertificate -PublicCertData $samplePublicCertData is a null-valued parameter value. -PublicCertData Assign value for $samplePublicCertData. ⚠️ New-AzVirtualNetworkGateway 4 5 Unassigned_Variable New-AzVirtualNetwork -Subnet $subnet is a null-valued parameter value. -Subnet Assign value for $subnet. ⚠️ Set-AzVirtualNetworkGateway 7 5 Mismatched_Parameter_Value_Type Set-AzVirtualNetworkGateway -NatRule $vngNatRules.NatRules is not an expected parameter value type. -NatRule Use correct parameter value type. Expected Type is Microsoft.Azure.Commands.Network.Models.PSVirtualNetworkGatewayNatRule. Now the type is .(Command). ️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can I please get a review on this PR? We are hoping to merge these changes before the release. Thank you. |
|
Do I create a new PR for this? I see that there are conflicts on the branch. @Nickcandy |
|
@diagaval Please resolve the conflicts first. |
|
Fixed the conflicts |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@diagaval Please update the help doc. |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
…val/resiliencyOnVng into release-network-2024-05-01
|
Fixed the helpdocs. |
|
Can anyone please help review this change? Hoping to get this in as part of the 2024-05-01 release. Thanks |
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
VeryEarly
added a commit
that referenced
this pull request
Dec 2, 2024
* [Network] - Add DefaultOutboundConnectivityEnabled property in PSNetworkInterface (#26512) * [Network] - Add DefaultOutboundConnectivityEnabled property in PSNetworkInterface * update changelog.md * Azure Firewall Autoscale Configuration Support (#26257) * Azure Firewall Autoscale Configuration Support * Help files with new parameters * add validation * New cmdlets for IPAM, VnV, Vnet, and AVNM SA (#26345) * new cmdlets * Help docs for IPAM cmdlets Update New-AzNetworkManagerIpamPoolStaticCidr.md Update Set-AzNetworkManagerIpamPool.md Update Remove-AzNetworkManagerIpamPoolStaticCidr.md Update Remove-AzNetworkManagerIpamPool.md Update New-AzNetworkManagerIpamPoolStaticCidr.md Update New-AzNetworkManagerIpamPool.md Update Get-AzNetworkManagerIpamPoolUsage.md Update Get-AzNetworkManagerIpamPoolStaticCidr.md Update Get-AzNetworkManagerIpamPool.md Update Get-AzNetworkManagerIpamPoolUsage.md Update Get-AzNetworkManagerIpamPool.md update set ipam pool cmdlet help doc updated help docs for new IPAM commands update help docs for ipam remove cmdlets update help docs for new Get cmdlets fix new ipam pool static cidr requirement * cmdlets for vnv * adding UTs * nomenclature fix * debug * mapping fix and inital help docs * update some help docs * NetworkManagerVerifierWorkspaceCRUD test * add location * update run crud * Security admin config changes * security rule update * updating change log * update for SA command * Reachability Analysis Run Test * all vnv tests working * NetworkManagerVerifierWorkspaceCRUD test * update run crud * Security admin config changes * security rule update * updating change log * update for SA command * Reachability Analysis Run Test * all vnv tests working * Help Doc Update nomenclature fix mapping fix and inital help docs add location remaining help docs fix change log fix changelog pt 2 debug update some help docs * all SA and network manager tests running * new commit to jumpstart the pipeline * build issues * add help doc online version links * fix help doc header * fix psd1 file * updated scenario test for analysis result * help doc fixes * fixes for analyze plural param bug * fix analyze example issue * fix generated sdk bug * add related links * param rename for analyze job * rerun build * adding tag testing * help doc update * added list test coverage and combined all vnv crud into one run crud * add and test tags for vnv * update test file * debug * fix az * add help documentation * checking analysis result obj and added SA aggre prop to help doc * adding all read only properties for run * trying to get check running * regenerated sdk and updated az.network --------- Co-authored-by: Sonalli S Sharma <[email protected]> Co-authored-by: sssharma24 <[email protected]> Co-authored-by: NanxiangLiu <[email protected]> * fix analysis run errors * Ipam cmdlet bug fixes * update help doc * display error message to customer * Adding resiliency model as an optional parameter on virtual network gateway for ExpressRoute (#26485) * initial commit * nit fixes * nit fix * Warning message updated * updated help docs --------- Co-authored-by: NanxiangLiu <[email protected]> * Suppress false positive cred scan --------- Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: phrazfipho <[email protected]> Co-authored-by: Ben Eshed <[email protected]> Co-authored-by: p-thompson <[email protected]> Co-authored-by: Sonalli S Sharma <[email protected]> Co-authored-by: sssharma24 <[email protected]> Co-authored-by: NanxiangLiu <[email protected]> Co-authored-by: p-thompson <[email protected]> Co-authored-by: diagaval <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
* [Network] - Add DefaultOutboundConnectivityEnabled property in PSNetworkInterface (#26512) * [Network] - Add DefaultOutboundConnectivityEnabled property in PSNetworkInterface * update changelog.md * Azure Firewall Autoscale Configuration Support (#26257) * Azure Firewall Autoscale Configuration Support * Help files with new parameters * add validation * New cmdlets for IPAM, VnV, Vnet, and AVNM SA (#26345) * new cmdlets * Help docs for IPAM cmdlets Update New-AzNetworkManagerIpamPoolStaticCidr.md Update Set-AzNetworkManagerIpamPool.md Update Remove-AzNetworkManagerIpamPoolStaticCidr.md Update Remove-AzNetworkManagerIpamPool.md Update New-AzNetworkManagerIpamPoolStaticCidr.md Update New-AzNetworkManagerIpamPool.md Update Get-AzNetworkManagerIpamPoolUsage.md Update Get-AzNetworkManagerIpamPoolStaticCidr.md Update Get-AzNetworkManagerIpamPool.md Update Get-AzNetworkManagerIpamPoolUsage.md Update Get-AzNetworkManagerIpamPool.md update set ipam pool cmdlet help doc updated help docs for new IPAM commands update help docs for ipam remove cmdlets update help docs for new Get cmdlets fix new ipam pool static cidr requirement * cmdlets for vnv * adding UTs * nomenclature fix * debug * mapping fix and inital help docs * update some help docs * NetworkManagerVerifierWorkspaceCRUD test * add location * update run crud * Security admin config changes * security rule update * updating change log * update for SA command * Reachability Analysis Run Test * all vnv tests working * NetworkManagerVerifierWorkspaceCRUD test * update run crud * Security admin config changes * security rule update * updating change log * update for SA command * Reachability Analysis Run Test * all vnv tests working * Help Doc Update nomenclature fix mapping fix and inital help docs add location remaining help docs fix change log fix changelog pt 2 debug update some help docs * all SA and network manager tests running * new commit to jumpstart the pipeline * build issues * add help doc online version links * fix help doc header * fix psd1 file * updated scenario test for analysis result * help doc fixes * fixes for analyze plural param bug * fix analyze example issue * fix generated sdk bug * add related links * param rename for analyze job * rerun build * adding tag testing * help doc update * added list test coverage and combined all vnv crud into one run crud * add and test tags for vnv * update test file * debug * fix az * add help documentation * checking analysis result obj and added SA aggre prop to help doc * adding all read only properties for run * trying to get check running * regenerated sdk and updated az.network --------- Co-authored-by: Sonalli S Sharma <[email protected]> Co-authored-by: sssharma24 <[email protected]> Co-authored-by: NanxiangLiu <[email protected]> * fix analysis run errors * Ipam cmdlet bug fixes * update help doc * display error message to customer * Adding resiliency model as an optional parameter on virtual network gateway for ExpressRoute (#26485) * initial commit * nit fixes * nit fix * Warning message updated * updated help docs --------- Co-authored-by: NanxiangLiu <[email protected]> * Suppress false positive cred scan --------- Co-authored-by: Vincent Dai <[email protected]> Co-authored-by: phrazfipho <[email protected]> Co-authored-by: Ben Eshed <[email protected]> Co-authored-by: p-thompson <[email protected]> Co-authored-by: Sonalli S Sharma <[email protected]> Co-authored-by: sssharma24 <[email protected]> Co-authored-by: NanxiangLiu <[email protected]> Co-authored-by: p-thompson <[email protected]> Co-authored-by: diagaval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an optional property of Resiliency model on Virtual Network Gateway Create and Update commands for ExpressRoute. This is used to provide customers an option to maintain resiliency on the gateways for ExpressRoute setups.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.