Preview Release ConnectedMachine 2024-07-31 #26541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzConnectedExtensionMetadata | Get-AzConnectedExtensionMetadata Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzConnectedExtensionMetadata | Get-AzConnectedExtensionMetadata changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzConnectedLicense | Get-AzConnectedLicense Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzConnectedLicense | Get-AzConnectedLicense changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzConnectedLicenseProfile | Get-AzConnectedLicenseProfile Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzConnectedLicenseProfile | Get-AzConnectedLicenseProfile changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzConnectedMachine | Get-AzConnectedMachine Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzConnectedMachine | Get-AzConnectedMachine changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzConnectedMachineExtension | Get-AzConnectedMachineExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzConnectedMachineExtension | Get-AzConnectedMachineExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzConnectedMachineRunCommand | Get-AzConnectedMachineRunCommand Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzConnectedMachineRunCommand | Get-AzConnectedMachineRunCommand changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzConnectedNetworkSecurityPerimeterConfiguration | Get-AzConnectedNetworkSecurityPerimeterConfiguration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzConnectedNetworkSecurityPerimeterConfiguration | Get-AzConnectedNetworkSecurityPerimeterConfiguration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzConnectedPrivateLinkScope | Get-AzConnectedPrivateLinkScope Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzConnectedPrivateLinkScope | Get-AzConnectedPrivateLinkScope changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzConnectedLicenseDetail | New-AzConnectedLicenseDetail Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| New-AzConnectedLicenseDetail | New-AzConnectedLicenseDetail changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| New-AzConnectedLicenseProfileFeature | New-AzConnectedLicenseProfileFeature Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| New-AzConnectedLicenseProfileFeature | New-AzConnectedLicenseProfileFeature changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Update-AzConnectedLicenseProfileFeature | Update-AzConnectedLicenseProfileFeature Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Update-AzConnectedLicenseProfileFeature | Update-AzConnectedLicenseProfileFeature changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ Update-AzConnectedMachineExtension 4 4 Mismatched_Parameter_Value_Type Update-AzConnectedMachineExtension -ExtensionParameter $extToUpdate is not an expected parameter value type. -ExtensionParameter Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtensionUpdate. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtension.(Command). ⚠️ Update-AzConnectedMachineRunCommand 1 2 Unassigned_Variable Update-AzConnectedMachineRunCommand -ResourceGroupName $env.ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupName. ⚠️ Update-AzConnectedMachineRunCommand 1 2 Unassigned_Variable Update-AzConnectedMachineRunCommand -RunCommandName $env.RunCommandName is a null-valued parameter value. -RunCommandName Assign value for $env.RunCommandName. ⚠️ Update-AzConnectedMachineRunCommand 1 2 Unassigned_Variable Update-AzConnectedMachineRunCommand -MachineName $env.MachineName is a null-valued parameter value. -MachineName Assign value for $env.MachineName. ⚠️ Update-AzConnectedMachineRunCommand 1 2 Unassigned_Variable Update-AzConnectedMachineRunCommand -Subscription $env.SubscriptionId is a null-valued parameter value. -Subscription Assign value for $env.SubscriptionId.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version. ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ConnectedMachine. Add a changelog record under Upcoming Release section with past tense.
⚠️ UX Metadata Check
⚠️ PowerShell Core - Windows
Type Module ResourceType SubResourceType Command Description ⚠️ Az.ConnectedMachine Microsoft.HybridCompute machines-licenseProfiles Get-AzConnectedLicenseProfile licenseProfileName is defined in path but cannot find in example ⚠️ Az.ConnectedMachine Microsoft.HybridCompute machines-licenseProfiles Remove-AzConnectedLicenseProfile licenseProfileName is defined in path but cannot find in example
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
|
@yaotongms Please fill in the examples and test cases for the cmdlets. |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@yaotongms Please kindly note there are breaking changes detected in the static analysis. Please confirm if these will really cause breaking on custom scripts. If so, may I know if you have submitted pre-announcements? |
examples and tests updated |
they shouldn't cause any breaking on custom scripts. |
|
changelog: Updated preview version api of HybridCompute to 2024-07-31 |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@yaotongms Please check the issues detected in CI. Please kindly note the code freeze date is 11/11 6PM PST. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
vidai-msft
requested changes
Nov 9, 2024
...onnectedMachine.Autorest/test/Get-AzConnectedNetworkSecurityPerimeterConfiguration.Tests.ps1
Outdated
Show resolved
Hide resolved
src/ConnectedMachine/ConnectedMachine.Autorest/test/New-AzConnectedLicenseProfile.Tests.ps1
Outdated
Show resolved
Hide resolved
...nnectedMachine/ConnectedMachine.Autorest/test/New-AzConnectedLicenseProfileFeature.Tests.ps1
Outdated
Show resolved
Hide resolved
...onnectedMachine/ConnectedMachine.Autorest/test/New-AzConnectedLicenseProfileUpdate.Tests.ps1
Outdated
Show resolved
Hide resolved
src/ConnectedMachine/ConnectedMachine.Autorest/test/New-AzConnectedMachineExtension.Tests.ps1
Outdated
Show resolved
Hide resolved
src/ConnectedMachine/ConnectedMachine.Autorest/test/New-AzConnectedMachineRunCommand.Tests.ps1
Outdated
Show resolved
Hide resolved
src/ConnectedMachine/ConnectedMachine.Autorest/test/Remove-AzConnectedLicenseProfile.Tests.ps1
Outdated
Show resolved
Hide resolved
...onnectedMachine/ConnectedMachine.Autorest/test/Remove-AzConnectedMachineRunCommand.Tests.ps1
Outdated
Show resolved
Hide resolved
src/ConnectedMachine/ConnectedMachine.Autorest/test/Update-AzConnectedLicenseProfile.Tests.ps1
Outdated
Show resolved
Hide resolved
...onnectedMachine/ConnectedMachine.Autorest/test/Update-AzConnectedMachineRunCommand.Tests.ps1
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
vidai-msft
reviewed
Nov 12, 2024
...nnectedMachine/ConnectedMachine.Autorest/test/New-AzConnectedLicenseProfileFeature.Tests.ps1
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
vidai-msft
added this to the Az 13.0.0 (November 2024, 2024-11-19)❗Breaking change release❗ milestone
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
General release on ConnectedMachine that includes the following new cmdlets:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.