Migrate Mdp from generation to main #26574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
️✔️Az.Accounts
|
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzMdpPool | Get-AzMdpPool Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMdpPool | Get-AzMdpPool changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMdpPoolAgent | Get-AzMdpPoolAgent Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMdpPoolAgent | Get-AzMdpPoolAgent changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMdpSku | Get-AzMdpSku Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMdpSku | Get-AzMdpSku changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Windows PowerShell - Windows
| Type | Cmdlet | Description | Remediation |
|---|---|---|---|
| Get-AzMdpPool | Get-AzMdpPool Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMdpPool | Get-AzMdpPool changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMdpPoolAgent | Get-AzMdpPoolAgent Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMdpPoolAgent | Get-AzMdpPoolAgent changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. | |
| Get-AzMdpSku | Get-AzMdpSku Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. | Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue | |
| Get-AzMdpSku | Get-AzMdpSku changes the confirm impact. Please ensure that the change in ConfirmImpact is justified | Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact. |
⚠️ Help Example Check
⚠️ PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static). ⚠️ Remove-AzMdpPool 2 3 Mismatched_Parameter_Value_Type Remove-AzMdpPool -InputObject $pool is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IMdpIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IPool.(Command). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static). ⚠️ Remove-AzMdpPool 2 3 Mismatched_Parameter_Value_Type Remove-AzMdpPool -InputObject $pool is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IMdpIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IPool.(Command).
⚠️ Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static). ⚠️ Remove-AzMdpPool 2 3 Mismatched_Parameter_Value_Type Remove-AzMdpPool -InputObject $pool is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IMdpIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IPool.(Command). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static). ⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static). ⚠️ Remove-AzMdpPool 2 3 Mismatched_Parameter_Value_Type Remove-AzMdpPool -InputObject $pool is not an expected parameter value type. -InputObject Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IMdpIdentity. Now the type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IPool.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
⚠️ Windows PowerShell - Windows
Type Cmdlet Description Remediation ⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
VeryEarly
previously approved these changes
Nov 4, 2024
|
|
azure-pipelines
bot
force-pushed
the
codegen/Mdp
branch
from
a190423
to
0647166
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate Mdp from generation to main
The last commit of src/Mdp in generation is:
commit 258c5d7 Author: Ajay [email protected] Date: Mon Nov 4 12:33:28 2024 +0900 support azure powershell for new RP Managed DevOps Pools (#26482) * support azure powershell for new RP Managed DevOps Pools * Add example for GetAzMdpPool * Add example for GEtAzMdpPoolAgent * Add example for other cmdlets * update docs * add tests * add recordings * fix build
Checklist