Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LocationName to Location for Get-AzMdpSku Cmdlet #26606

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ajaykn
Copy link

@ajaykn ajaykn commented Nov 5, 2024

Description

Fixing the LocationName parameter to Location for Get-AzMdpSku cmdlet

image

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Nov 5, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.Mdp
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzMdpPool Get-AzMdpPool Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzMdpPool Get-AzMdpPool changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzMdpPoolAgent Get-AzMdpPoolAgent Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzMdpPoolAgent Get-AzMdpPoolAgent changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzMdpSku Get-AzMdpSku Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzMdpSku Get-AzMdpSku changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static).
⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static).
⚠️ New-AzMdpPool 1 1 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static).
⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -AgentProfile '{'kind': 'stateless'}' is not an expected parameter value type. -AgentProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IAgentProfile. Now the type is string.(Static).
⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -OrganizationProfile '{'kind': 'AzureDevOps','organizations': [{'url': 'https://dev.azure.com/contoso-org','projects': null,'parallelism': 1}],'permissionProfile': {'kind': 'CreatorOnly'}}' is not an expected parameter value type. -OrganizationProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IOrganizationProfile. Now the type is string.(Static).
⚠️ New-AzMdpPool 2 3 Mismatched_Parameter_Value_Type New-AzMdpPool -FabricProfile '{'kind': 'Vmss', 'sku': {'name': 'Standard_DS12_v2'}, 'storageProfile': { 'osDiskStorageAccountType': 'Standard','dataDisks': []},'images': [{'resourceId': '/Subscriptions/0ac520ee-14c0-480f-b6c9-0a90c58ffff/Providers/Microsoft.Compute/Locations/eastus2/Publishers/canonical/ArtifactTypes/VMImage/Offers/0001-com-ubuntu-server-focal/Skus/20_04-lts-gen2/versions/latest','buffer': '*'}]}' is not an expected parameter value type. -FabricProfile Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Mdp.Models.IFabricProfile. Now the type is string.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows

@ajaykn ajaykn marked this pull request as ready for review November 5, 2024 13:59
@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidai-msft vidai-msft self-assigned this Nov 5, 2024
@vidai-msft vidai-msft merged commit 80349e2 into Azure:generation Nov 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants