Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding examples for constrained role delegation #26612

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

SebastianClaesson
Copy link
Contributor

Adding examples to showcase how constrained role delegation can be done with PowerShell.

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Adding examples to showcase how constrained role delegation can be done with PowerShell.
Copy link

azure-client-tools-bot-prd bot commented Nov 6, 2024

️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Contributor

Thank you for your contribution SebastianClaesson! We will review the pull request and get back to you soon.

@VeryEarly VeryEarly self-assigned this Nov 12, 2024
@VeryEarly
Copy link
Contributor

Hi @SebastianClaesson , thanks for the contribution, please mask guid in the examples.

The built-in roles have the same GUID in every tenant.
@SebastianClaesson
Copy link
Contributor Author

Hi @SebastianClaesson , thanks for the contribution, please mask guid in the examples.

Hi @VeryEarly,

I've now added two GUIDs for the Owner and User Access Administrator role to show-case examples.
These GUIDs are well-known by each Azure tenant, meaning they are the same in each and every one.
I've attached documentation to reference the roles.

Would this be OK? Or do you want them masked?
I thought it gave more context if we provide well-known roles as examples.

VeryEarly
VeryEarly previously approved these changes Nov 15, 2024
@VeryEarly
Copy link
Contributor

Hi @SebastianClaesson , thanks for the contribution, please mask guid in the examples.

Hi @VeryEarly,

I've now added two GUIDs for the Owner and User Access Administrator role to show-case examples. These GUIDs are well-known by each Azure tenant, meaning they are the same in each and every one. I've attached documentation to reference the roles.

Would this be OK? Or do you want them masked? I thought it gave more context if we provide well-known roles as examples.

sounds good, thanks.

@VeryEarly
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit ee61f8f into Azure:main Nov 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants