Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Astro from generation to main #26643

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Migrate Astro from generation to main #26643

merged 2 commits into from
Nov 8, 2024

Conversation

azure-pipelines[bot]
Copy link
Contributor

Description

Migrate Astro from generation to main
The last commit of src/Astro in generation is:
commit 2c3163a Author: lijinpei2008 [email protected] Date: Fri Nov 8 22:25:15 2024 +0800 [Astro] Update astro custom logic for New-AzAstroOrganization and Update-AzAstroOrganization (#26641) * update astro custom logic * update custom logic * update test case * update custom logic

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Nov 8, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Astro
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzAstroOrganization Get-AzAstroOrganization Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzAstroOrganization Get-AzAstroOrganization changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzAstroOrganization Get-AzAstroOrganization Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzAstroOrganization Get-AzAstroOrganization changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Contributor

Thank you for your contribution azure-pipelines[bot]! We will review the pull request and get back to you soon.

@vidai-msft vidai-msft self-assigned this Nov 8, 2024
@vidai-msft
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor Author

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@vidai-msft vidai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidai-msft vidai-msft merged commit c2b91f8 into main Nov 8, 2024
12 checks passed
@lijinpei2008 lijinpei2008 deleted the codegen/Astro branch November 8, 2024 15:21
Nickcandy added a commit that referenced this pull request Nov 21, 2024
* update readme and generate sdk

* modifications to match generated code

* update polling method

* testbasic cluster sfmc

* more test recordings

* apptype test recordings

* add managed service test

* adding managedapptypeversion recording

* add manaegdApp recording

* add managedAppType recording

* update readme

* undo breaking changes

* undo breaking change

* Fix Readme.md

* generate code

* update commands

* undo generated code changes

* remove unnecessary cast

* remove unnecessary casting

* update iptag

* revert iptag change

* unchanged sdk

* updates

* update sdk

* generate sfrp sdk

* update test recordings

* update resource values

* update all tests

* updated sdk

* update sfmc sdk

* Update README.md

* Update README.md

* add breaking.csv file

* update breakinchanges.csv

* more updates

* target Pr

* Update ChangeLog.md

* Az.service fabric preview (#25124)

* update readme and generate sdk

* modifications to match generated code

* update polling method

* testbasic cluster sfmc

* more test recordings

* apptype test recordings

* add managed service test

* adding managedapptypeversion recording

* add manaegdApp recording

* add managedAppType recording

* update readme

* undo breaking changes

* undo breaking change

* Fix Readme.md

* generate code

* update commands

* undo generated code changes

* remove unnecessary cast

* remove unnecessary casting

* update iptag

* revert iptag change

* unchanged sdk

* updates

* update sdk

* generate sfrp sdk

* update test recordings

* update resource values

* update all tests

* updated sdk

* update sfmc sdk

* Update README.md

* Update README.md

* add breaking.csv file

* update breakinchanges.csv

* more updates

* target Pr

* Update ChangeLog.md

---------

Co-authored-by: Lei Jin <[email protected]>
Co-authored-by: NoriZC <[email protected]>

* upgrade servicefabric to 4.0.0-preview

* sanitize password in example

* resolve bad merge

* Adding examples for constrained role delegation

Adding examples to showcase how constrained role delegation can be done with PowerShell.

* Remove GitHub Token From CI Pipeline (#26602)

Remove GitHub Token From CI Pipeline

* Migrate ConnectedKubernetes from generation to main (#26630)

* Move ConnectedKubernetes to main

* Update ChangeLog.md

* Update ChangeLog.md

* Update ChangeLog.md

---------

Co-authored-by: azure-powershell-bot <[email protected]>
Co-authored-by: NoriZC <[email protected]>

* add new sdk and test recordings

* Migrate DevCenter from generation to main (#26626)

* Move DevCenter to main

* Add change log and suppress breaking change

---------

Co-authored-by: azure-powershell-bot <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>

* Add support for creating cross-subscription Geo-replicated databases (#26598)

* add cross subscription support for NewAzSqlDatabaseSecondary cmdlet

* run replication tests to validate cross-sub change

* update changelog

* fix typo on resource group assert

* update help document with new param

* Sanitize data

---------

Co-authored-by: Vincent Dai <[email protected]>

* Update a string value in Get PR Changed Files Script (#26637)

* Update get-pr-changed-files.yml

* Update get-pr-changed-files.yml

* [Storage] Mirgate Storage file cmdlets to Track2 SDK  (#26575) (#26594)

* [Storage] Mirgate Storage file cmdlets to Track2 SDK  (#26575)

* REsolve merge conflicts

* Resolve merge conflicts

* remove breaking change warnings

* Update changelog

* Add breaking change exception

* Remove unused file InvalidCLoudFileShare.cs

* Update RemoveFilePathTrailingDot helper function per comments

---------

Co-authored-by: yifanz7 <[email protected]>
Co-authored-by: Yifan Zhang <[email protected]>

* Downgrade the servity of didn't find defined parameter in path to 2 (#26639)

* Migrate Astro from generation to main (#26643)

* Move Astro to main

* Update ChangeLog.md

---------

Co-authored-by: azure-powershell-bot <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>

* update chagelog

* Fix JSON format issue (#26646)

* Migrate App from generation to main (#26644)

* Move App to main

* update changelog and BreakingChangeIssues.csv

---------

Co-authored-by: azure-powershell-bot <[email protected]>
Co-authored-by: Jinpei Li <[email protected]>

* Migrate NeonPostgres from generation to main (#26647)

* Move NeonPostgres to main

* Update Az.NeonPostgres.psd1

---------

Co-authored-by: azure-powershell-bot <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>

* [Key Vault] Add Secret URI Parameter to Key Vault Secret Cmdlets (#26222)

* Added secretUri support for all the 'secret' cmdlets

* Updated Changelog

* Added ResourceId aliases for backwards compatibility

* Added Tests, Secret Data Class

* Updated Help Docs

* Use Typed varaibles

* Add example usages in help docs

* Error Suppression

* Change Data Class Accessibility

* Move Split Logic to Constructor

* Added uri format to help docs

* [Accounts] Add Long-Running Operation (LRO) Support to Invoke-AzRestMethod (#26225)

* Refactored existing code

* Added general LRO support

* Removed excess log statements

* Updated Changelog

* Added comments

* Removed log statements

* Regression Compatiblility

* Removed debug logs

* Updated the help docs

* Update param name, Add use case example

* Updated help docs

* Updated description

* Update to add ArgumentCompleter

* Delay the Get-AzAccessToken Breaking Change (#26625)

* Delay the Get-AzAccessToken breaking change

* Update the doc of Get-AzAccessToken

* Address review comments

* Address review comments

---------

Co-authored-by: Vincent Dai <[email protected]>

* Update azure-powershell-modules.md (#26650)

* Update azure-powershell-modules.md

* Update azure-powershell-modules.md

* Update azure-powershell-modules.md

* Bump up version for ConnectedKubernetes (#26635)

* remove secrets

* Migrate ConnectedMachine from generation to main (#26657)

* Move ConnectedMachine to main

* Update ChangeLog.md

* Fix signature issues.

---------

Co-authored-by: azure-powershell-bot <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>

* Remove ProgressAction and tweak the change log (#26661)

* [Devtestlabs] Migrated DevTestLabs SDK to generated SDK (#26648)

* generate DevTestLabs by autorest v2

* add DevTestLabs.Management.Sdk

* use 2016-05-15 api vesion

* migrate DevTestLabs to autorest.powershell

* update and record the test

* Update ChangeLog.md

* Revert "Update ChangeLog.md"

This reverts commit 4788e93.

* Update ChangeLog.md

---------

Co-authored-by: Yabo Hu <[email protected]>

* Changing to two simple roles for examples

The built-in roles have the same GUID in every tenant.

* Remove get-github-token-steps.yml (#26660)

* Update code-gen.yml

* Delete .azure-pipelines/util/get-github-token-steps.yml

* Add engineer docs for example analyzer (#26663)

* Create example-analyzer.md

* refine docs

* debug way

* Migrate DesktopVirtualization from generation to release-2024-11-19 (#26668)

* Move DesktopVirtualization to release-2024-11-19

* Remove ProgressAction

---------

Co-authored-by: Vincent Dai <[email protected]>

* Remove alias for cmdlet Resolve-AzError (#26666)

* Remove alias for cmdlet Resolve-AzError

* Suppress breaking change

* Update ChangeLog.md

---------

Co-authored-by: Yabo Hu <[email protected]>

* Fixed overriding of Bicep parameters in Deployment Stack cmdlets to support SecureString parameters. (#26670)

* Fixed overriding of Bicep parameters in Deployment Stack cmdlets to support SecureString parameters.

* Added session record.

---------

Co-authored-by: Dante DG <test>

* Migrate ConnectedKubernetes from generation to main (#26675)

* Move ConnectedKubernetes to main

* Update ChangeLog.md

---------

Co-authored-by: Yabo Hu <[email protected]>

* Migrate DnsResolver from generation to release-2024-11-19 (#26676)

* Move DnsResolver to release-2024-11-19

* Update change log and suppress breaking changes

* Updated change log

---------

Co-authored-by: Vincent Dai <[email protected]>

* Updated verbose status log in deployment stacks deployment. (#26681)

* Updated verbose status log in deployment stacks deployment.

* Update ChangeLog.md

---------

Co-authored-by: Dante DG <test>
Co-authored-by: Yabo Hu <[email protected]>

* Migrate ContainerInstance from generation to release-2024-11-19 (#26690)

* Move ContainerInstance to release-2024-11-19

* Remove ProgressAction and update change log

* Reset recording

---------

Co-authored-by: Vincent Dai <[email protected]>

* Bump up version for ConnectedKubernetes (#26686)

* [DataFactory]Powershell Release (#26702)

* release-2024-11-19 (#26706)

* bump minor versions at least to distinguish with LTS

* Bump a major version for Az.Compute

* Remove BreakingChangeIssues.csv for bumping major version

* Bump Version for Az 13.0.0

* add community contributors

* SyntaxChangeLog-Az13.md

* add community contributors in changelog.md

* Update Start-AzNetAppFilesPeerExternalCluster.md (#26684)

* Resolve the solutions with dependencies (#26710)

* Update model creation parameter location or order

* Add migration guide

* Update documentation/migration-guides/Az.13.0.0-migration-guide.md

Co-authored-by: yifanz7 <[email protected]>

* Update documentation/migration-guides/Az.13.0.0-migration-guide.md

Co-authored-by: yifanz7 <[email protected]>

* Update documentation/migration-guides/Az.13.0.0-migration-guide.md

Co-authored-by: yifanz7 <[email protected]>

* Update ChangeLog.md

* Update documentation/migration-guides/Az.13.0.0-migration-guide.md

Co-authored-by: Wei Wei <[email protected]>

* Update ExampleIssues.csv

* remove secrets

* Updating migration guide typos for Az 13.0.0 (#26722)

* Fixing migration guide for SQL DAG.

* Chaning string to lowercase.

---------

Co-authored-by: jovancevic123 <[email protected]>

* Update migration guide. (#26723)

* update file

* update

* update

* remove secrets

* remove more secrets

* remove more secrests

* remove passwords

* Update CredScanSuppressions.json

* Update CredScanSuppressions.json

---------

Co-authored-by: Lei Jin <[email protected]>
Co-authored-by: NoriZC <[email protected]>
Co-authored-by: Yabo Hu <[email protected]>
Co-authored-by: Sebastian Claesson <[email protected]>
Co-authored-by: Yan Xu <[email protected]>
Co-authored-by: azure-pipelines[bot] <36771401+azure-pipelines[bot]@users.noreply.github.com>
Co-authored-by: azure-powershell-bot <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>
Co-authored-by: alecbain <[email protected]>
Co-authored-by: yifanz7 <[email protected]>
Co-authored-by: Yifan Zhang <[email protected]>
Co-authored-by: Yunchi Wang <[email protected]>
Co-authored-by: Jinpei Li <[email protected]>
Co-authored-by: Yash <[email protected]>
Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: NanxiangLiu <[email protected]>
Co-authored-by: JoyerJin <[email protected]>
Co-authored-by: Beisi Zhou <[email protected]>
Co-authored-by: Dante <[email protected]>
Co-authored-by: Jingshu918 <[email protected]>
Co-authored-by: Wei Wei <[email protected]>
Co-authored-by: jovancevic123 <[email protected]>
Co-authored-by: jovancevic123 <[email protected]>
Co-authored-by: lijinpei2008 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants