Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{cdn} Upgrade cdn api version to 2024-09-01 #26645

Closed
wants to merge 45 commits into from

Conversation

Ptnan7
Copy link
Member

@Ptnan7 Ptnan7 commented Nov 9, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Ptnan7 and others added 30 commits July 31, 2024 14:34
* gen

* update

* update

* update

* update

* update

* complete

* update

* update

* update

* add migration map

* complete rename

* rename CanCdnProfileToAFD

* add preview message

* rename

* typo fix

* fix docs in enable custom domain https

* example fix

* rerun ut

* rerun ut

* comments

* UT rerun for move cdn profile to afd

---------

Co-authored-by: Jingnan Xu <[email protected]>
Copy link

azure-client-tools-bot-prd bot commented Nov 9, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
🔄Az.Cdn
️✔️Build
️✔️PowerShell Core - Windows
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Test
️✔️PowerShell Core - MacOS
🔄PowerShell Core - Windows

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

@Ptnan7 Our CI detected this PR has breaking changes. Can you please confirm? Please also fix the examples issues as described in the CI.

Copy link

github-actions bot commented Nov 9, 2024

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

# For new modules, please avoid setting 3.x using the use-extension method and instead, use 4.x as the default option
use-extension:
"@autorest/powershell": "3.x"
"@autorest/powershell": "4.x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.x is the by default value. If you plan to migrate to 4, then can remove the use-extension attribute.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

- where:
parameter-name: IdentityType
set:
breaking-change:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to roll out breaking changes in this Ignite or just the pre-announcement? I see these information mismatches. We will release Az 13 during Ignite. However, the pre-announcement should be released 2 or 3 sprints before the major release. It is not allowed to roll out breaking changes directly without announcement.

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

Hi @Ptnan7 , please targeting next build event as @vidai-msft suggested, close this for now and please recreate new one after then.

@VeryEarly VeryEarly closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants