-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{cdn} Upgrade cdn api version to 2024-09-01 #26645
Conversation
* gen * update * update * update * update * update * complete * update * update * update * add migration map * complete rename * rename CanCdnProfileToAFD * add preview message * rename * typo fix * fix docs in enable custom domain https * example fix * rerun ut * rerun ut * comments * UT rerun for move cdn profile to afd --------- Co-authored-by: Jingnan Xu <[email protected]>
…ersion-09-01 merge
️✔️Az.Accounts
🔄Az.Cdn
|
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@Ptnan7 Our CI detected this PR has breaking changes. Can you please confirm? Please also fix the examples issues as described in the CI. |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
src/Cdn/Cdn.Autorest/README.md
Outdated
# For new modules, please avoid setting 3.x using the use-extension method and instead, use 4.x as the default option | ||
use-extension: | ||
"@autorest/powershell": "3.x" | ||
"@autorest/powershell": "4.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.x is the by default value. If you plan to migrate to 4, then can remove the use-extension
attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
- where: | ||
parameter-name: IdentityType | ||
set: | ||
breaking-change: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you planning to roll out breaking changes in this Ignite or just the pre-announcement? I see these information mismatches. We will release Az 13 during Ignite. However, the pre-announcement should be released 2 or 3 sprints before the major release. It is not allowed to roll out breaking changes directly without announcement.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @Ptnan7 , please targeting next build event as @vidai-msft suggested, close this for now and please recreate new one after then. |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.