Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIO Powershell SDK #27211

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

AIO Powershell SDK #27211

wants to merge 12 commits into from

Conversation

hmmorales
Copy link
Member

@hmmorales hmmorales commented Feb 25, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@NoriZC
Copy link
Contributor

NoriZC commented Feb 25, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@NoriZC
Copy link
Contributor

NoriZC commented Feb 25, 2025

@hmmorales please read https://gist.github.com/VeryEarly/53cf3372a1c7c7c6f5e1ffd3949513a5 and make sure nothing is missed. I see that for now your PR does not inlcude generate-info file.

@hmmorales
Copy link
Member Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27211 in repo Azure/azure-powershell

@hmmorales
Copy link
Member Author

@hmmorales please read https://gist.github.com/VeryEarly/53cf3372a1c7c7c6f5e1ffd3949513a5 and make sure nothing is missed. I see that for now your PR does not inlcude generate-info file.

Hi @NoriZC I updated the PR, can you take another look?

@NoriZC
Copy link
Contributor

NoriZC commented Feb 27, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

Hey @hmmorales, you can check the failed pipeline here

It is because "generate-info.json was not found!"

Copy link

github-actions bot commented Mar 3, 2025

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants