Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some mocking from Event Hubs #43073

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Remove some mocking from Event Hubs #43073

wants to merge 6 commits into from

Conversation

alzimmermsft
Copy link
Member

Description

Completely removes the usage of Mockito in the Checkpoint Store libraries and cleans out some usages of Mockito in azure-messaging-eventhubs.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Nov 22, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 22, 2024 •
edited
Loading

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conniey conniey Awaiting requested review from conniey conniey will be requested when the pull request is marked ready for review conniey is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy will be requested when the pull request is marked ready for review anuchandy is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova will be requested when the pull request is marked ready for review lmolkova is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@alzimmermsft alzimmermsft

Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alzimmermsft @azure-sdk