Add vmId to the Rntbd Health Check Error Message #43079
Open
+93
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue 42811
Currently vmId is part of our client-side diagnostics. However, diagnostics can only be obtained if an operation succeeds or fails - if it hangs, we will not see anything. There was a WMT Sev2 where we saw channel health check failure logs (the log itself has the source and destination IP) but not the vmId, so we couldn't diagnose the VM well enough. With this change, the vmId can be extracted from health check logs and correlated so we can get VM level visibility.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines