Replace random data generation with pseudo random #43118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
requested review from
ibrahimrabab,
seanmcc-msft,
ibrandes and
kyleknap
as code owners
|
API change check API changes are not detected in this pull request. |
ibrahimrabab
approved these changes
Dec 2, 2024
kyleknap
approved these changes
Dec 2, 2024
| @@ -269,7 +269,20 @@ public static byte[] getRandomByteArray(int size, TestResourceNamer testResource | |||
| long seed = UUID.fromString(testResourceNamer.randomUuid()).getMostSignificantBits() & Long.MAX_VALUE; | |||
| Random rand = new Random(seed); | |||
| byte[] data = new byte[size]; | |||
| rand.nextBytes(data); | |||
| byte[] pseudoRandom = new byte[31]; | |||
| rand.nextBytes(pseudoRandom); | |||
There was a problem hiding this comment.
It would be great if we could have a comment here on why we are using this approach to randomness. Mainly, unless someone is looking at the blame and track it down to this pull request, it is not obvious that it is needed in order to reduce the download size of the test assets and someone could unknowingly change it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes random data generation logic to generate pseudo random data to reduce git pack file sizes and help future work in sessions records where request and response bodies may be compressed (to help shrink session record sizes).
The following are how
.gitfolder sizes shrunk due to this change:Blob
Changefeed
Cryptography
NIO
Datalake
Shares
This reduce
.gitfolder sizes from 1258 MB to 688 MB, saving 570 MB each time a full set of session records need to be downloaded.A follow-up to this change should be an investigation in changing how much data the Cryptography library uses in testing to see if the session record sizes can be shrunk as the request and response bodies are encrypted data streams which won't be able to compress well given encrypted data randomness.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines