Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change clientcore's baseline to Java 17 #43152

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Change clientcore's baseline to Java 17 #43152

wants to merge 8 commits into from
+852 −3,610

Conversation

alzimmermsft
Copy link
Member

Description

Changes the baseline Java version for clientcore packages to Java 17 and folds the JDK HttpClient HttpClient-based implementation into the core library.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Dec 2, 2024
@github-actions github-actions bot added Azure.Core azure-core clientcore common common module used by all azure SDKs (e.g. client, Mgmt) labels Dec 2, 2024
samvaity
samvaity reviewed Dec 2, 2024
View reviewed changes
sdk/clientcore/core/src/main/java/io/clientcore/core/util/auth/CompositeChallengeHandler.java
@@ -0,0 +1,52 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.
package io.clientcore.core.util.auth;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: line break.
moved to its own file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this as ChallengeHandler was exposing a public ClientLogger as interfaces cannot have private constants and the logger was only being used by this inner class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samvaity samvaity samvaity left review comments

@hallipr hallipr Awaiting requested review from hallipr hallipr will be requested when the pull request is marked ready for review hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard will be requested when the pull request is marked ready for review weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp will be requested when the pull request is marked ready for review benbp is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio will be requested when the pull request is marked ready for review JimSuplizio is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar will be requested when the pull request is marked ready for review srnagar is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay will be requested when the pull request is marked ready for review g2vinay is a code owner

@conniey conniey Awaiting requested review from conniey conniey will be requested when the pull request is marked ready for review conniey is a code owner

@rujche rujche Awaiting requested review from rujche rujche will be requested when the pull request is marked ready for review rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy will be requested when the pull request is marked ready for review Netyyyy is a code owner

@saragluna saragluna Awaiting requested review from saragluna saragluna will be requested when the pull request is marked ready for review saragluna is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan will be requested when the pull request is marked ready for review moarychan is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 will be requested when the pull request is marked ready for review vcolin7 is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles will be requested when the pull request is marked ready for review JonathanGiles is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core clientcore common common module used by all azure SDKs (e.g. client, Mgmt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alzimmermsft @samvaity