Making ShareFileSymbolicLinkInfo Package Private #45512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
ibrandes
requested review from
seanmcc-msft,
kyleknap,
alzimmermsft and
gunjansingh-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the ShareFileSymbolicLinkInfo model to restrict its public API by making its parameterized constructor package-private while retaining a default constructor for internal use. The changes aim to prevent API bloat from additional public constructors and update dependent code to use an accessor pattern for instance creation.
- Made the parameterized constructor package-private in ShareFileSymbolicLinkInfo.java and added a static block for accessor registration.
- Updated ModelHelper.java to utilize the new helper method for constructing ShareFileSymbolicLinkInfo.
- Introduced ShareFileSymbolicLinkInfoHelper.java to encapsulate internal instance creation.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/models/ShareFileSymbolicLinkInfo.java | Modified constructor visibility and added a default constructor and static accessor registration. |
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/implementation/util/ModelHelper.java | Replaced direct instantiation with the helper method call. |
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/implementation/accesshelpers/ShareFileSymbolicLinkInfoHelper.java | Introduced new helper to support internal creation via accessor registration. |
...-file-share/src/main/java/com/azure/storage/file/share/models/ShareFileSymbolicLinkInfo.java
Show resolved
Hide resolved
...m/azure/storage/file/share/implementation/accesshelpers/ShareFileSymbolicLinkInfoHelper.java
Show resolved
Hide resolved
|
/check-enforcer override |
ibrandes
added a commit
that referenced
this pull request
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses API View comment.
While other models in File Share may not follow this pattern, many of the older models exposed public constructors even when it wasn’t necessary. In contrast, we can make the constructor for ShareFileSymbolicLinkInfo internal. This allows us to avoid adding new public constructor overloads every time a property is added in the future—something that has led to bloated Blob models.