Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mgmt] verify compute rp from tsp converted swagger #32026

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[mgmt] verify compute rp from tsp converted swagger #32026

wants to merge 3 commits into from
+22,055 −128,808

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 commented Dec 3, 2024 •
edited
Loading

#32007

use swagger config which convered from https://github.com/Azure/azure-rest-api-specs/blob/feature/cplat-typespecTest/specification/compute/Compute.Management :

input-file:
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/ComputeRP.json

swagger config with last release:

input-file:
  - Microsoft.Compute/common-types/v1/common.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/computeRPCommon.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/virtualMachineScaleSet.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/virtualMachine.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/virtualMachineImage.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/virtualMachineExtensionImage.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/availabilitySet.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/proximityPlacementGroup.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/dedicatedHost.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/sshPublicKey.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/image.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/restorePoint.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/capacityReservation.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/logAnalytic.json
  - Microsoft.Compute/ComputeRP/stable/2024-07-01/runCommand.json 
  - Microsoft.Compute/DiskRP/stable/2024-03-02/diskRPCommon.json
  - Microsoft.Compute/DiskRP/stable/2024-03-02/disk.json
  - Microsoft.Compute/DiskRP/stable/2024-03-02/diskAccess.json
  - Microsoft.Compute/DiskRP/stable/2024-03-02/diskEncryptionSet.json
  - Microsoft.Compute/DiskRP/stable/2024-03-02/diskRestorePoint.json
  - Microsoft.Compute/DiskRP/stable/2024-03-02/snapshot.json
  - Microsoft.Compute/Skus/stable/2021-07-01/skus.json
  - Microsoft.Compute/GalleryRP/stable/2023-07-03/galleryRPCommon.json
  - Microsoft.Compute/GalleryRP/stable/2023-07-03/gallery.json
  - Microsoft.Compute/GalleryRP/stable/2023-07-03/sharedGallery.json
  - Microsoft.Compute/GalleryRP/stable/2023-07-03/communityGallery.json
  - Microsoft.Compute/CloudserviceRP/stable/2022-09-04/cloudService.json

@kazrael2119 kazrael2119 requested review from qiaozha, MaryGao and a team as code owners December 3, 2024 02:31
@kazrael2119 kazrael2119 marked this pull request as draft December 3, 2024 02:31
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Dec 3, 2024
kazrael2119
kazrael2119 commented Dec 3, 2024
View reviewed changes
sdk/compute/arm-compute/CHANGELOG.md
Comment on lines +129 to +151
- Removed operation group CloudServiceOperatingSystems
- Removed operation group CloudServiceRoleInstances
- Removed operation group CloudServiceRoles
- Removed operation group CloudServices
- Removed operation group CloudServicesUpdateDomain
- Removed operation group CommunityGalleries
- Removed operation group CommunityGalleryImages
- Removed operation group CommunityGalleryImageVersions
- Removed operation group DiskAccesses
- Removed operation group DiskEncryptionSets
- Removed operation group DiskRestorePointOperations
- Removed operation group Disks
- Removed operation group Galleries
- Removed operation group GalleryApplications
- Removed operation group GalleryApplicationVersions
- Removed operation group GalleryImages
- Removed operation group GalleryImageVersions
- Removed operation group GallerySharingProfile
- Removed operation group ResourceSkus
- Removed operation group SharedGalleries
- Removed operation group SharedGalleryImages
- Removed operation group SharedGalleryImageVersions
- Removed operation group Snapshots
Copy link
Contributor Author

@kazrael2119 kazrael2119 Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are caused by removing the resource-types with old apiversions

@kazrael2119 kazrael2119 changed the title [mgmt] verify compute rp from tsp->swagger [mgmt] verify compute rp from tsp converted swagger Dec 3, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/arm-compute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazrael2119 @azure-sdk