Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Finalize on API for ModelReaderWriter integration with JsonSerializer #40778

Open
m-nash opened this issue Dec 14, 2023 · 2 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@m-nash
Copy link
Member

m-nash commented Dec 14, 2023

Library name

System.ClientModel

Please describe the feature.

For the initial release we are making JsonModelConverter internal. The following discussion needs to be resolved before we make it public again. #40766 (comment)

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 14, 2023
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Azure.Core and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Dec 14, 2023
@AtOMiCNebula
Copy link

@m-nash, Is there an expectation of when this will be addressed and the model types will be linked up with [JsonConverter]s? I've brought this up in various issues here for over a year now (like in #25699 (comment)), but ResourceGraph returns a payload of a serialized list of resources (essentially IList<KeyVaultData> instead of KeyVaultData), and ModelReaderWriter can't currently handle that (AFAICT). Integrating with JsonConverter would though, especially if the model types had the attribute on them (so I don't have to provide my own Options).

I just noticed this because Azure.ResourceManager.KeyVault shipped a stable update with the new model serialization/deserialization in it, and I was sad that it still can't meet my needs (again, AFAICT). 😞

@annelo-msft annelo-msft added this to the Backlog milestone May 20, 2024
@annelo-msft
Copy link
Member

@m-nash, has this issue been completed now that JsonModelConverter has shipped in SCM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

4 participants