Final naming updates for ModelReaderWriter #40766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update name of JsonModelConverter
m-nash
requested review from
JoshLove-msft,
christothes,
annelo-msft and
KrzysztofCwalina
as code owners
…o mnash-moveMrwNamespace
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
tg-msft
reviewed
Dec 13, 2023
KrzysztofCwalina
approved these changes
Dec 13, 2023
|
Super nit - the links to APIView don't resolve once the comments are closed, so it's hard to understand from the links in the description the comments are addressing. Probably an APIView issue/bug, but until it's resolved, it'd be helpful to clarify what's happening in the PR description |
|
Another nit - possible APIView bug - the ClientModel APIView doesn't look like it's getting linked from the PR comment: #40766 (comment) |
tg-msft
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following comments from apiview
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.