Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tracing: we should strip correation-context/and/or baggage when calling Azure services #41543

Open
lmolkova opened this issue Jan 24, 2024 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Milestone

Comments

@lmolkova
Copy link
Member

lmolkova commented Jan 24, 2024

Library name and version

Azure.Core

Describe the bug

Activity.Baggage is propagated by default via Correlation-Context and can be too big:

  • It can affect perf by increasing header size
  • it can reach service header size limits

HttpClient propagates Correlation-Context (by default) as long as it's set on the activity.

Expected behavior

Correlation-Context is user app concern and should not be passed to Azure services.

We can set all baggage items to null using Activity.SetBaggage. If it's proven to be unreliable/not performant, we should work with .NET to turn off baggage propagation (to specific endpoints) in BCL.

Actual behavior

If users add things into their activity.Baggage, we propagate them along with our activities

Reproduction Steps

TBD

Environment

No response

@lmolkova lmolkova added the OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) label Jan 24, 2024
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 24, 2024
@kirankumarkolli
Copy link
Member

Thanks you @lmolkova for creating the issue.
One of ComsosDB CX has a livesite incident due to this. Cosmos service has header size limitations of 20KB and context overshoot that, resulting in BadRequests.

@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jan 25, 2024
@annelo-msft annelo-msft added this to the Backlog milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Development

No branches or pull requests

4 participants