Add model converter for Stj and Mrw integration #45445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
reviewed
Aug 9, 2024
sdk/core/System.ClientModel/src/ModelReaderWriter/ModelJsonConverter.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Aug 9, 2024
sdk/core/System.ClientModel/src/ModelReaderWriter/ModelJsonConverter.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Aug 9, 2024
sdk/core/System.ClientModel/src/ModelReaderWriter/ModelJsonConverter.cs
Outdated
Show resolved
Hide resolved
|
Would it make sense to provide samples to help end-users understand how to use the converter? |
|
Please add a CHANGELOG entry for this addition. |
sdk/core/System.ClientModel/src/ModelReaderWriter/ModelJsonConverter.cs
Outdated
Show resolved
Hide resolved
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/core/System.ClientModel/src/ModelReaderWriter/ModelJsonConverter.cs
Outdated
Show resolved
Hide resolved
|
Also, what's the difference between JsonModelConverter and ModelJsonConverter? Both of these seem to be present in this branch |
Great question, looks like someone added this back in for preview as internal only, it appears it was only removed for the initial 1.0.0 GA. It also looks like we renamed it |
KrzysztofCwalina
approved these changes
Aug 12, 2024
annelo-msft
reviewed
Aug 12, 2024
annelo-msft
reviewed
Aug 12, 2024
sdk/core/System.ClientModel/src/ModelReaderWriter/JsonModelConverter.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Aug 12, 2024
sdk/core/System.ClientModel/src/ModelReaderWriter/ModelJsonConverter.cs
Outdated
Show resolved
Hide resolved
validate content changes such as naming policy are not
annelo-msft
reviewed
Aug 12, 2024
sdk/core/System.ClientModel/tests/ModelReaderWriter/Models/ResourceProviderDataTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openai/openai-dotnet#67