Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net - pullrequest #47957

Merged
merged 2 commits into from
Feb 4, 2025
Merged

net - pullrequest #47957

merged 2 commits into from
Feb 4, 2025

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jan 23, 2025

This PR...

  • Adds a new net - pullrequest build.
    • This PR dynamically expands/contracts to only build and test the changed packages.
    • If Azure.Core or Azure.ResourceManager are present in the set of packages that have been changed, their dependencies are also discovered and distributed sparsely to test runs. This completely replaces the static AdditionalDependency leg that currently exists only on net - core and net - resourcemanager. It utilizes exactly the same dependency discovery that original leg utilized. (eng/service.proj ProjectDependsOn target)
    • The dependency discovery is fairly slow still, so it's limited to Azure.Core/Azure.ResourceManager. That can be adjusted.

Todo:

  • Add language-settings function to handle which packages should be build/tested if a PR is purely non-sdk changes.
  • Fix the docs generation to honor the changed packages
  • Re-add dev versioning save of save-package-props
    • This doesn't exist in main that I can tell anymore.
  • Fix broken pkg props build stage in original net CI builds
  • Fix existing build legs which are broken by the change to propertyoverridefile usage in build-test.
    • resourcemanager
    • core
  • Invoke the $eachService steps in static analysis (where Ben commented effectively) to at least attempt to shift these to pshell job. Going to make this entire job parallel.
  • Run nightly core to ensure I make absolutely certain we're all good
  • One last cleanup rebase.

@scbedd scbedd self-assigned this Jan 23, 2025
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Jan 23, 2025
eng/service.proj Outdated Show resolved Hide resolved
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks reasonable.

eng/pipelines/templates/jobs/ci.tests.yml Outdated Show resolved Hide resolved
eng/pipelines/templates/jobs/ci.tests.yml Outdated Show resolved Hide resolved
eng/pipelines/templates/jobs/ci.yml Outdated Show resolved Hide resolved
@scbedd
Copy link
Member Author

scbedd commented Feb 4, 2025

/azp run net - pullrequest

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd scbedd merged commit 7a8178f into main Feb 4, 2025
55 checks passed
@scbedd scbedd deleted the pipelinev3 branch February 4, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
Status: 🎊 Closed
Development

Successfully merging this pull request may close these issues.

4 participants