-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net - pullrequest
#47957
Merged
Merged
net - pullrequest
#47957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
hallipr,
weshaggard,
benbp,
seanmcc-msft,
amnguye,
jaschrep-msft,
schaabs,
tg-msft,
jalauzon-msft,
nickliu-msft and
jsquire
as code owners
January 23, 2025 21:43
hallipr
reviewed
Jan 23, 2025
hallipr
reviewed
Jan 23, 2025
hallipr
approved these changes
Jan 23, 2025
weshaggard
reviewed
Jan 23, 2025
weshaggard
reviewed
Jan 23, 2025
weshaggard
reviewed
Jan 23, 2025
weshaggard
reviewed
Jan 23, 2025
weshaggard
reviewed
Jan 23, 2025
weshaggard
reviewed
Jan 23, 2025
weshaggard
reviewed
Jan 23, 2025
weshaggard
reviewed
Jan 23, 2025
scbedd
commented
Jan 24, 2025
weshaggard
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks reasonable.
benbp
reviewed
Jan 28, 2025
benbp
reviewed
Jan 28, 2025
benbp
reviewed
Jan 28, 2025
benbp
reviewed
Jan 28, 2025
hallipr
reviewed
Jan 31, 2025
hallipr
reviewed
Jan 31, 2025
hallipr
reviewed
Jan 31, 2025
hallipr
reviewed
Jan 31, 2025
/azp run net - pullrequest |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
net - pullrequest
build.Azure.Core
orAzure.ResourceManager
are present in the set of packages that have been changed, their dependencies are also discovered and distributed sparsely to test runs. This completely replaces the staticAdditionalDependency
leg that currently exists only onnet - core
andnet - resourcemanager
. It utilizes exactly the same dependency discovery that original leg utilized. (eng/service.proj
ProjectDependsOn
target)Azure.Core
/Azure.ResourceManager
. That can be adjusted.Todo:
Re-add dev versioning save of save-package-propsbuild
stage in original net CI buildsresourcemanager
core
Invoke the $eachService steps in static analysis (where Ben commented effectively) to at least attempt to shift these to pshell job.Going to make this entire job parallel.