[Storage][DataMovement] Fix preserving FileChangedOn during transfers #48009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
jalauzon-msft
commented
Jan 30, 2025
sdk/storage/Azure.Storage.DataMovement.Files.Shares/src/DataMovementSharesExtensions.cs
Show resolved
Hide resolved
jalauzon-msft
commented
Jan 30, 2025
...torage/Azure.Storage.DataMovement.Files.Shares/tests/ShareDirectoryStartTransferCopyTests.cs
Show resolved
Hide resolved
jalauzon-msft
commented
Jan 30, 2025
jalauzon-msft
requested review from
seanmcc-msft,
amnguye,
jaschrep-msft,
schaabs,
tg-msft and
nickliu-msft
as code owners
amnguye
reviewed
Jan 30, 2025
...e/Azure.Storage.DataMovement.Files.Shares/src/Azure.Storage.DataMovement.Files.Shares.csproj
Outdated
Show resolved
Hide resolved
|
Somehow the changes are affecting the blob tests |
amnguye
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes a fix for preserving
FileChangedOnfor copies where the destination is a File-Share file. Basically, at the end of the transfer we need to call Set Properties again to set he FileChangedOn in case it was updated during the transfer. This also meant we need to call to complete the transfer on the destination even for single-shit copies.Adjusted some tests and added some new ones to catch this issue. Also, a little cleanup in the job part code while I was there.