Skip to content

[AutoRelease] t2-servicefabricmanagedclusters-2025-05-22-78728(can only be merged by SDK owner) #41259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

azure-sdk
Copy link
Collaborator

@Copilot Copilot AI review requested due to automatic review settings May 22, 2025 02:44
@azure-sdk
Copy link
Collaborator Author

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Service Fabric Managed Clusters SDK to use the new Python Code Generator and the 2025-03-01-preview API, refactors operations imports, and enhances client configuration and endpoint handling.

  • Replace "AutoRest Code Generator" headers with "Python Code Generator" and bump version to 2.1.0b3
  • Flatten individual operation modules into a unified Operations class and update __init__.py imports
  • Update client to select base URL from cloud settings, rename _send_request to send_request, and expose dynamic ARM endpoints

Reviewed Changes

Copilot reviewed 158 out of 158 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
sdk/servicefabricmanagedclusters/azure-mgmt-servicefabricmanagedclusters/azure/mgmt/servicefabricmanagedclusters/aio/operations/init.py Consolidated all operation classes into .Operations and updated imports
sdk/servicefabricmanagedclusters/azure-mgmt-servicefabricmanagedclusters/azure/mgmt/servicefabricmanagedclusters/aio/_configuration.py Added base_url parameter, bumped default API version to 2025-03-01-preview
sdk/servicefabricmanagedclusters/azure-mgmt-servicefabricmanagedclusters/azure/mgmt/servicefabricmanagedclusters/aio/_client.py Introduced dynamic ARM endpoint resolution, renamed _send_request to send_request
sdk/servicefabricmanagedclusters/azure-mgmt-servicefabricmanagedclusters/azure/mgmt/servicefabricmanagedclusters/aio/_utils/serialization.py Removed legacy UTC fallback and cleaned up serializer/deserializer class definitions
sdk/servicefabricmanagedclusters/azure-mgmt-servicefabricmanagedclusters/azure/mgmt/servicefabricmanagedclusters/_version.py Bumped SDK version from 2.1.0b2 to 2.1.0b3
Comments suppressed due to low confidence (2)

sdk/servicefabricmanagedclusters/azure-mgmt-servicefabricmanagedclusters/azure/mgmt/servicefabricmanagedclusters/aio/_client.py:181

  • You’ve renamed _send_request to send_request. Consider adding a _send_request alias or deprecation warning to preserve backward compatibility for any existing consumers relying on the private method.
def send_request(self, request: HttpRequest, *, stream: bool = False, **kwargs: Any) -> HttpResponse:

sdk/servicefabricmanagedclusters/azure-mgmt-servicefabricmanagedclusters/azure/mgmt/servicefabricmanagedclusters/aio/operations/init.py:16

  • With the flattening of individual operation modules into one _operations file, ensure that unit tests cover each operation’s behavior under the new structure.
from ._operations import ApplicationsOperations  # type: ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants