Users/bambriz/feedrangehotfix0 #41270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where querychangefeed doesn't return items that have PartitionKey Values that use Hash V1. This also fixes issue where one couldn't query changefeed for specific HPK PK values that weren't prefix pks.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for legacy Hash V1 partition key hashing (using MurmurHash3 32-bit) so change feed queries return items for containers using V1 keys, and it updates both sync and async code paths and tests accordingly.
- Implemented V1 hashing logic in PartitionKey (_truncate_for_v1_hashing, murmurhash3_32, and binary encoding)
- Propagated partition key
versionin container/client constructors and query logic - Added/updated sync and async tests to validate change feed behavior on Hash V1, Hash V2, and hierarchical keys
- Updated CHANGELOG with new release entry
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/tests/test_changefeed_partition_key_variation_async.py | New async tests for change feed across Hash V1/V2 and HPK cases |
| sdk/cosmos/azure-cosmos/tests/test_changefeed_partition_key_variation.py | New sync tests for change feed across Hash V1/V2 and HPK cases |
| sdk/cosmos/azure-cosmos/azure/cosmos/partition_key.py | Added V1 hashing, truncate, 32-bit Murmur, and binary encoding |
| sdk/cosmos/azure-cosmos/azure/cosmos/container.py | Forwarded version when constructing PartitionKey |
| sdk/cosmos/azure-cosmos/azure/cosmos/aio/_cosmos_client_connection_async.py | Forwarded version in async client partition key logic |
| sdk/cosmos/azure-cosmos/azure/cosmos/aio/_container.py | Forwarded version in async container partition key logic |
| sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_murmurhash3.py | Added murmurhash3_32 implementation |
| sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_integers.py | Introduced _UInt32 and encode/decode helpers for 32-bit values |
| sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py | Updated sync client to check and use version in prefix queries |
| sdk/cosmos/azure-cosmos/CHANGELOG.md | Documented the V1 change feed fix in 4.12.0b2 release notes |
Comments suppressed due to low confidence (1)
sdk/cosmos/azure-cosmos/azure/cosmos/partition_key.py:211
- The
with (BytesIO() as ms):syntax is invalid. It should bewith BytesIO() as ms:to correctly open the context manager.
with (BytesIO() as ms):
sdk/cosmos/azure-cosmos/tests/test_changefeed_partition_key_variation_async.py
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/tests/test_changefeed_partition_key_variation_async.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where querychangefeed doesn't return items that have PartitionKey Values that use Hash V1. This also fixes issue where one couldn't query changefeed for specific HPK PK values that weren't prefix pks. A Murmurhash3 32bit x86 algorithm was implemented and made to match what backend expects for the EPK of Hash V1 Partition Key Values.