Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new): Azure Data Explorer (Kusto) #440

Merged
merged 54 commits into from
Aug 23, 2023
Merged

feat(new): Azure Data Explorer (Kusto) #440

merged 54 commits into from
Aug 23, 2023

Conversation

vlahane
Copy link
Contributor

@vlahane vlahane commented Jul 6, 2023

Description

closes: #287

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, edit the PR description and run through the relevant checklist below.

Enable GitHub Worksflows in your fork to enable auto-generation of assets with our GitHub Action.
To trigger GitHub Actions after auto-generation, add a GitHub PAT as a secret in your forked repository called PAT.

Adding a new module

  • A proposal has been submitted and approved.
  • I have included "Closes #{module_proposal_issue_number}" in the PR description.
  • I have run brm validate locally to verify the module files.
  • I have run deployment tests locally to ensure the module is deployable.

@vlahane
Copy link
Contributor Author

vlahane commented Jul 6, 2023

@dciborow please review created from your PR: #308,

Error:

##[error]New-AzResourceGroupDeployment: 12:40:51 PM - The deployment 'main.test' failed with error(s). Showing 2 out of 2 error(s).
Status Message: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details. (Code: DeploymentFailed)

  • The subscription is not registered to use namespace 'Microsoft.Kusto'. See https://aka.ms/rps-not-found for how to register subscriptions. (Code: MissingSubscriptionRegistration)
    • The subscription is not registered to use namespace 'Microsoft.Kusto'. See https://aka.ms/rps-not-found for how to register subscriptions. (Code:MissingSubscriptionRegistration)
      Status Message: At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details. (Code: DeploymentFailed)
  • The subscription is not registered to use namespace 'Microsoft.Kusto'. See https://aka.ms/rps-not-found for how to register subscriptions. (Code: MissingSubscriptionRegistration)
    • The subscription is not registered to use namespace 'Microsoft.Kusto'. See https://aka.ms/rps-not-found for how to register subscriptions. (Code:MissingSubscriptionRegistration)
      CorrelationId: 671d00fe-cffa-42b1-a1ee-197455c18908

@shenglol
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@shenglol
Copy link
Contributor

There are errors in the test file:

�[31;1mNew-AzResourceGroupDeployment: �[31;1mCannot retrieve the dynamic parameters for the cmdlet. WARNING: Symbolic name support in ARM is experimental, and should be enabled for testing purposes only. Do not enable this setting for any production usage, or you may be unexpectedly broken at any time!
D:\a\1\s\modules\storage\data-explorer\test\prereq.test.bicep(48,21) : Error BCP036: The property "kind" expected a value of type "error | null" but the provided value is of type "'Hash'".
D:\a\1\s\modules\storage\data-explorer\test\main.test.bicep(13,15) : Error BCP104: The referenced module has errors.�[0m

@vlahane
Copy link
Contributor Author

vlahane commented Aug 16, 2023

There are errors in the test file:

�[31;1mNew-AzResourceGroupDeployment: �[31;1mCannot retrieve the dynamic parameters for the cmdlet. WARNING: Symbolic name support in ARM is experimental, and should be enabled for testing purposes only. Do not enable this setting for any production usage, or you may be unexpectedly broken at any time!
D:\a\1\s\modules\storage\data-explorer\test\prereq.test.bicep(48,21) : Error BCP036: The property "kind" expected a value of type "error | null" but the provided value is of type "'Hash'".
D:\a\1\s\modules\storage\data-explorer\test\main.test.bicep(13,15) : Error BCP104: The referenced module has errors.�[0m

I think, this must be a bug in bicep,


referencing module from repository might introduce some error, as per I remember this was working last month.

@shenglol will you please check

@shenglol
Copy link
Contributor

There are errors in the test file:

�[31;1mNew-AzResourceGroupDeployment: �[31;1mCannot retrieve the dynamic parameters for the cmdlet. WARNING: Symbolic name support in ARM is experimental, and should be enabled for testing purposes only. Do not enable this setting for any production usage, or you may be unexpectedly broken at any time!
D:\a\1\s\modules\storage\data-explorer\test\prereq.test.bicep(48,21) : Error BCP036: The property "kind" expected a value of type "error | null" but the provided value is of type "'Hash'".
D:\a\1\s\modules\storage\data-explorer\test\main.test.bicep(13,15) : Error BCP104: The referenced module has errors.�[0m

I think, this must be a bug in bicep,

referencing module from repository might introduce some error, as per I remember this was working last month.
@shenglol will you please check

Yeah, this does seem to be a bug. I created an issue to track this. For now, I think we can use the any function as a workaround to bypass type checking:

            ...
            partitionKey: {
              kind: any('Hash')
            }
            ...

@vlahane
Copy link
Contributor Author

vlahane commented Aug 18, 2023

@shenglol I think instead of using workaround, as fix is merge can't we get new bicep release out soon?

@shenglol
Copy link
Contributor

shenglol commented Aug 18, 2023

@shenglol I think instead of using workaround, as fix is merge can't we get new bicep release out soon?

We don't have a plan to do another 20.x release since the bug only affects ARM template modules. We will be publishing 21.x early next month. I'm comfortable with either approach, so the decision to apply the workaround or wait for the new release is up to you.

@vlahane
Copy link
Contributor Author

vlahane commented Aug 22, 2023

@shenglol changes are done updated with any, thanks! :)

@shenglol shenglol merged commit eb55bdd into Azure:main Aug 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Module Proposal]: Azure Data Explorer Clusters [Kusto/clusters]
3 participants