Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit null when serializing a nullable union type, but accept it if encountered in the allowedValues constraint #11546

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Aug 16, 2023

Resolves #11544

Microsoft Reviewers: Open in CodeFlow

…t if encountered in the allowedValues constraint
@jeskew jeskew requested a review from a team August 16, 2023 22:48
@github-actions
Copy link
Contributor

Test Results (win-x64)

       33 files  ±0         33 suites  ±0   34m 54s ⏱️ +52s
10 417 tests +2  10 381 ✔️ +2  36 💤 ±0  0 ±0 
12 633 runs  +2  12 597 ✔️ +2  36 💤 ±0  0 ±0 

Results for commit 343ce32. ± Comparison against base commit c653d20.

@github-actions
Copy link
Contributor

Test Results (linux-x64)

       33 files  ±0         33 suites  ±0   39m 22s ⏱️ + 6m 53s
10 405 tests +2  10 369 ✔️ +2  36 💤 ±0  0 ±0 
12 622 runs  +2  12 586 ✔️ +2  36 💤 ±0  0 ±0 

Results for commit 343ce32. ± Comparison against base commit c653d20.

@github-actions
Copy link
Contributor

Test Results (linux-musl-x64)

       33 files  ±0         33 suites  ±0   35m 29s ⏱️ + 1m 27s
10 405 tests +2  10 369 ✔️ +2  36 💤 ±0  0 ±0 
12 622 runs  +2  12 586 ✔️ +2  36 💤 ±0  0 ±0 

Results for commit 343ce32. ± Comparison against base commit c653d20.

@github-actions
Copy link
Contributor

Test Results (osx-x64)

       33 files  ±0         33 suites  ±0   1h 35m 21s ⏱️ -5s
10 409 tests +2  10 373 ✔️ +3  36 💤 ±0  0  - 1 
12 626 runs  +2  12 590 ✔️ +3  36 💤 ±0  0  - 1 

Results for commit 343ce32. ± Comparison against base commit c653d20.

Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeskew jeskew merged commit 5eb49f6 into main Aug 17, 2023
52 checks passed
@jeskew jeskew deleted the jeskew/11544 branch August 17, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-defined type error for ARM template modules
2 participants