Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add an explicit dependency on an existing resource when the deployments engine will use the GET response #15693

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Only add an explicit dependency on an existing resource when the deployments engine will use the GET response #15693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
040c5c5
Reapply "Only add an explicit dependency on an existing resource when…
jeskew Nov 14, 2024
b56dd0c
Update dependency expression generation to account for indexing at a …
jeskew Nov 14, 2024
1fefdb0
Update baselines
jeskew Nov 14, 2024
a61a5fe
Update NoUnnecessaryDependsOnRule to account for new output format of…
jeskew Nov 14, 2024
a8e19d0
Add repro test
jeskew Nov 14, 2024
9445fbb
Consolidate added dependency inference tests
jeskew Nov 15, 2024
2facf4f
Merge branch 'main' into jeskew/15513-bis
jeskew Nov 15, 2024
56d041c
Mark an accidentally public method as `private static`
jeskew Nov 15, 2024
f2a10b3
Merge branch 'main' into jeskew/15513-bis
jeskew Nov 25, 2024
a708a01
Update dependency inference to special-case `scope` in the same way i…
jeskew Nov 25, 2024
7f65b4d
Regenerate baselines
jeskew Nov 25, 2024
851f527
Back out change to symbolic name dependency inference
jeskew Nov 27, 2024
47376bb
Revert "Back out change to symbolic name dependency inference"
jeskew Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Bicep.Cli/Rpc/CliJsonRpcServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public async Task<GetDeploymentGraphResponse> GetDeploymentGraph(GetDeploymentGr
{
var compilation = await GetCompilation(compiler, request.Path);
var model = compilation.GetEntrypointSemanticModel();
var dependenciesBySymbol = ResourceDependencyVisitor.GetResourceDependencies(model, new() { IncludeExisting = true })
var dependenciesBySymbol = ResourceDependencyVisitor.GetResourceDependencies(model)
.Where(x => !x.Key.Type.IsError())
.ToImmutableDictionary(x => x.Key, x => x.Value);

Expand All @@ -200,7 +200,7 @@ public async Task<GetDeploymentGraphResponse> GetDeploymentGraph(GetDeploymentGr
foreach (var (symbol, dependencies) in dependenciesBySymbol)
{
var source = nodesBySymbol.TryGetValue(symbol);
foreach (var dependency in dependencies.Where(d => d.Kind == ResourceDependencyKind.Primary))
foreach (var dependency in dependencies)
{
var target = nodesBySymbol.TryGetValue(dependency.Resource);
if (source is { } && target is { })
Expand Down
Loading