-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension configuration updates for stacks extensibility support. #16444
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (8)
- src/Bicep.Core.IntegrationTests/ModuleTests.cs: Evaluated as low risk
- src/Bicep.Core/LanguageConstants.cs: Evaluated as low risk
- src/Bicep.Core/Semantics/TemplateSpecSemanticModel.cs: Evaluated as low risk
- src/Bicep.Core/Semantics/EmptySemanticModel.cs: Evaluated as low risk
- src/Bicep.Core/TypeSystem/DeclaredTypeManager.cs: Evaluated as low risk
- src/Bicep.Core/Semantics/ISemanticModel.cs: Evaluated as low risk
- src/Bicep.Core/TypeSystem/Types/NamespaceType.cs: Evaluated as low risk
- src/Bicep.Core/Semantics/SemanticModel.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Bicep.Core/Semantics/Metadata/ExtensionMetadata.cs:12
- The parameter name 'ConfigType' should be renamed to 'ConfigurationType' for consistency with other parts of the codebase.
ObjectType? ConfigType,
Test this change out locally with the following install scripts (Action run 13661726405) VSCode
Azure CLI
|
Dotnet Test Results 68 files - 49 68 suites - 49 28m 54s ⏱️ - 22m 16s For more details on these failures, see this check. Results for commit 6c65a29. ± Comparison against base commit 437f796. This pull request removes 3602 and adds 636 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
c449227
to
4f5c360
Compare
4f5c360
to
277d7d9
Compare
Contributing a Pull Request
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.
Contributing to documentation
Contributing an example
We are integrating the Bicep examples into the Azure QuickStart Templates. If you'd like to contribute new example
.bicep
files that showcase abilities of the language, please follow these instructions to add them directly there. We can still take bug reports and fixes for the existing examples for the time being.dotnet test
Contributing a feature
Contributing a snippet
I have a snippet that is either a single, generic resource or multi resource that uses parent-child syntax
I have checked that there is not an equivalent snippet already submitted
I have used camelCasing unless I have a justification to use another casing style
I have placeholders values that correspond to their property names (e.g.
dnsPrefix: 'dnsPrefix'
), unless it's a property that MUST be changed or parameterized in order to deploy. In that case, I use 'REQUIRED' e.g. keyDataI have my symbolic name as the first tab stop ($1) in the snippet. e.g. res-aks-cluster.bicep
I have a resource name property equal to "name"
If applicable, I have set the
location
property tolocation: /*${<id>:location}*/'location'
(notresourceGroup().location
) where<id>
is a placeholder id, and addedparam location string
to the test's main.bicep file so that the resulting main.combined.bicep file used in the tests compiles without errorsI have verified that the snippet deploys correctly when used in the context of an actual bicep file
e.g.
Microsoft Reviewers: Open in CodeFlow