Skip to content

Fix naming for externalInput definition property #16809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

levimatheri
Copy link
Contributor

@levimatheri levimatheri commented Apr 3, 2025

Fix naming mistake: options -> config.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Test this change out locally with the following install scripts (Action run 14255498944)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 14255498944
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 14255498944"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 14255498944
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 14255498944"

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Dotnet Test Results

    78 files   -     39      78 suites   - 39   33m 22s ⏱️ - 15m 59s
12 012 tests  -     13  12 012 ✅  -     13  0 💤 ±0  0 ❌ ±0 
27 782 runs   - 13 886  27 782 ✅  - 13 886  0 💤 ±0  0 ❌ ±0 

Results for commit 81ba214. ± Comparison against base commit 9efd301.

This pull request removes 1787 and adds 609 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
�Խ
�0\u0010\u0007��>E�\u0003�\��
\u001d\u0004\u0007+���*�\u0006��*m��/o\u001c����\u0017�ߘ\u001c��?�_�v�l檚!(�g�ոg�z�~\u0005
	�
'\u001c�6����<p�\u001b[�V>q�\u000f\u0012\u0003j��p	��(\u0004�f���
��޶k\u000fbz��.��̵l_\u001f�ky�U��k\u0006\u001d����'z��.\u0014�3\u0000�\u0001)\u0010	7�H���d�������z4KǛ�j1���O�o�\u0014\u0004A\u0010��\u0005\u001b\u0012Ă\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��K
�0\u0010\u0006�=EN�f�i�.�w�\u0015�\u0016|�T��\u0005��\u000b�E���
�[�0d���do�]a�E�\u0008\u0002�D��I� \u0006�#H�\u0001�H&)�\u0015Ƈ�7	���~�%��Aj�m{.�\u001c\u00085)\u0005&\u0013\u0012��Lm|�0�\u0003~��)���U�\u0013��r�@95��E������\u0013}ʿ��\u0001\u0012i\u0003Z\u0011��\u0003��_$�����c�
�(��5<\u0001�\u0014T�\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��K
�0\u0010\u0006�=E�\u0001Ҥy�
ݻ\u0011�x�؎��Z�
\u0005��\u000bq��\u000f�|��\u000f�$LX���\u0006m�e�@(\u0015224�\u0018�:�[B\u0001\u0011��	\u0007�
!�\u0019��\u000e����ke��~P���>g\u0018\u000bP\u0012�H�fZp�\u0012\u0016����Ċ\u0016�>��<ņ]�[�Ƴ�����z|�o�+�6�\*��\u0000�F�\u0008�p��K�If����A�}�M�I��\u0016�\u0003���\u001e����ܽy��y�y\u0001ǫ\u0008e\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�ӽ
�0\u0010\u0007��>E�\u0003��$MT��"��\u0000�=�bki+\u0014�w�\u001d�%��\u000f�����]H�,��v�6Ūf\u0012�\u0008\u0019\u0019\u001a�h���=P@��p�M�w�v�M\u001cnuc�n�)f� ��m�\u001cc0J\u001a!�TLs\u0010�EWI�\u0015X��6�8+Rlٹ�\u0016}s�n����G�7\u001coƷ�w���2Fj�\\u000b�u\u0014���$����;
�\u0005�%&
�[�\u000fX\u0005kz��\u001a\u001fs��y���	C��e\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Ի
�0\u0014\u0006��>E�\u0003���
\u001d\u0004\u0007+R\u0005�U�
X�U�
\u0005_�t\u0010�\u0016�^\u0004�9\u0007�	�\u000f���^\u001b���D�H�#�7lI�[�\u001b�ֈz�\u0000+�\u0015\u0000��}�\u0016��҅]e�Y?�*��43!Q�)J1�H�9\u000e��-�;J$�w]]�4OL���-o������t���p3��\u001fS���\u0014��aI\u0001�B0��Q2����zQ|\n��is���\u0002�\u001fx�\u001c�q��\u0000\u001a���\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003���
�0\u000c\u0007��\u0014>AM��΃�\u001d�
e\u0013��u���ػ�\u001e\u0006;(�8\u001d��cCHJ��xo�]n�yUKB�b)�\u0006�f\u001e}\u001f`�\u0002�\u000b\u00080	'BD�워h��V~�%f� ��ls.�\u000c
�Q
��Nu
�\u001b_;L�0��攵�����K]����jX������}kƧ�\u0003(�l\u000ci$���}�\u0017�����X{� \u0008�`
O.�}s\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createArray(1, 2, 3)","array","[
  1
  2
  3
]")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_banned_function_replacement ("createObject('key', 'value')","object","{
  key: 'value'
}")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\n")
Bicep.Core.IntegrationTests.DecompilationTests ‑ Decompiler_handles_strings_with_newlines ("
","\r\n")
…

@levimatheri levimatheri enabled auto-merge (squash) April 3, 2025 23:33
@levimatheri levimatheri merged commit 82da263 into main Apr 4, 2025
47 checks passed
@levimatheri levimatheri deleted the levi/fix-external-input-property branch April 4, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants