file util other functions spec and header #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
anporumb,
mattdurak,
dcristoloveanu,
jebrando,
darobs,
ipg2013,
parth21999,
cyrus-jackson,
jasmineymlo,
RohitG28,
ACKPaul and
M-iceberg
added 2 commits
July 21, 2023 10:14
mattdurak
reviewed
Jul 21, 2023
| MOCKABLE_FUNCTION(, bool, file_util_set_file_pointer_ex, HANDLE, handle_input, LARGE_INTEGER, distance_to_move, PLARGE_INTEGER, new_file_pointer, uint32_t, move_method); | ||
| ``` | ||
|
|
||
| If there are any failures, `file_util_set_file_pointer_ex` shall fail and return false. |
There was a problem hiding this comment.
missing the description sentence, here and below #Resolved
mattdurak
reviewed
Jul 21, 2023
|
|
||
| `file_util_set_end_of_file` shall succeed and return true. | ||
|
|
||
| ### file_util_write_file_ex |
There was a problem hiding this comment.
We decided to implement a CreateThreadpoolIO. Then the write file function would go within that. So that is something I will be working on implementing now.
There was a problem hiding this comment.
Yeah that makes sense, I suppose this will be updated with some additional parameter which is an OVERLAPPED* on win32 and something equivalent on Linux
mattdurak
reviewed
Jul 21, 2023
| MOCKABLE_FUNCTION(, bool, file_util_get_file_size, PLARGE_INTEGER*, file_size, HANDLE, handle_input); | ||
| ``` | ||
|
|
||
| `file_util_get_file_size_ex` implements the GetFileSizeEx function in Linux. |
mattdurak
reviewed
Jul 21, 2023
| MOCKABLE_FUNCTION(, bool, file_util_get_file_size, PLARGE_INTEGER*, file_size, HANDLE, handle_input); | ||
| ``` | ||
|
|
||
| `file_util_get_file_size_ex` implements the GetFileSizeEx function in Linux. |
mattdurak
reviewed
Jul 21, 2023
|
|
||
| If there are any failures, `file_util_get_file_size_ex` shall fail and return false. | ||
|
|
||
| `file_util_get_file_size_ex` shall succeed and return true. |
There was a problem hiding this comment.
nit: should go after the "shall call stat..." line #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.