Linux: Removing threadpool_open and threadpool_close along with SM states #416
+396
−891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
requested review from
anporumb,
avranju,
mattdurak,
dcristoloveanu,
jebrando,
darobs,
ipg2013 and
parth21999
nishudeshu
changed the title
|
/azp run #Resolved |
|
Azure Pipelines successfully started running 1 pipeline(s). #Resolved |
nishudeshu
changed the title
Removed. In reply to: 2512829554 Refers to: linux/src/threadpool_linux.c:32 in a679d72. [](commit_id = a679d72, deletion_comment = False) |
|
No pipelines are associated with this pull request. |
jebrando
reviewed
Dec 2, 2024
| wake_by_address_single(threadpool->task_array[current_index].pending_work_item_count_ptr); | ||
| /* Codes_SRS_THREADPOOL_LINUX_05_046: [ threadpool_work_func shall release the shared SRW lock by calling srw_lock_release_exclusive. ]*/ | ||
| (void)interlocked_decrement(threadpool->task_array[current_index].pending_work_item_count_ptr); | ||
| wake_by_address_single(threadpool->task_array[current_index].pending_work_item_count_ptr); |
There was a problem hiding this comment.
Since you're only waiting up if the value is zero, then you need to have an if on the decrement as to only wait on zero, it makes it more efficient.
if (interlocked_decrement(...) == 0)
{
wake_by_address_single(...);
}
jebrando
reviewed
Dec 2, 2024
|
|
||
| srw_lock_release_exclusive(threadpool_ptr->srw_lock); | ||
| wake_by_address_single(task_item->pending_work_item_count_ptr); |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing Threadpool Open and Close and SM states.