New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: Removing threadpool_open and threadpool_close along with SM states #416

Merged

nishudeshu merged 15 commits into master from nisdeshmukh/threadpool_open_close_linux

Dec 4, 2024

Contributor

nishudeshu commented Nov 24, 2024

Removing Threadpool Open and Close and SM states.


          Specs for removing threadpool open and close and SM states

41b962b

microsoft-github-policy-service bot requested review from anporumb, avranju, mattdurak, dcristoloveanu, jebrando, darobs, ipg2013 and parth21999

November 24, 2024 01:04


          Linux Threadpool open and close removal

a679d72

nishudeshu changed the title ~~Specs for removing threadpool open and close and SM states~~ Linux removing threadpool_open and threadpool_close along with SM states

Contributor Author

nishudeshu commented Dec 1, 2024 •

edited

Loading

/azp run #Resolved

azure-pipelines bot commented Dec 1, 2024 •

edited by nishudeshu

Loading

Azure Pipelines successfully started running 1 pipeline(s). #Resolved

nishudeshu changed the title ~~Linux removing threadpool_open and threadpool_close along with SM states~~ Linux: Removing threadpool_open and threadpool_close along with SM states

nishudeshu enabled auto-merge (squash)

December 1, 2024 17:44

dcristoloveanu reviewed

View reviewed changes

linux/devdoc/threadpool_linux_requirements.md Outdated Show resolved Hide resolved

Member

dcristoloveanu commented Dec 2, 2024 •

edited by nishudeshu

Loading

#include "c_pal/sm.h"

This is not needed any longer #Resolved

Refers to: linux/src/threadpool_linux.c:32 in a679d72. [](commit_id = a679d72, deletion_comment = False)

Contributor Author

nishudeshu commented Dec 2, 2024

#include "c_pal/sm.h"

Removed.

In reply to: 2512829554

Refers to: linux/src/threadpool_linux.c:32 in a679d72. [](commit_id = a679d72, deletion_comment = False)

nishudeshu disabled auto-merge

December 2, 2024 21:25

microsoft-github-policy-service bot requested a review from dcristoloveanu

December 2, 2024 21:25

azure-pipelines bot commented Dec 2, 2024 •

edited by nishudeshu

Loading

No pipelines are associated with this pull request. #Resolved

jebrando reviewed

View reviewed changes

linux/src/threadpool_linux.c Outdated Show resolved Hide resolved

jebrando reviewed

View reviewed changes

linux/src/threadpool_linux.c Outdated Show resolved Hide resolved


          Addressed Dan's and Jelani's comments

7685a86

Contributor Author

nishudeshu commented Dec 2, 2024 •

edited

Loading

/azp run #Resolved

microsoft-github-policy-service bot requested a review from jebrando

December 2, 2024 21:36

azure-pipelines bot commented Dec 2, 2024 •

edited by nishudeshu

Loading

Azure Pipelines successfully started running 1 pipeline(s). #Resolved

Contributor

jebrando commented Dec 2, 2024 •

edited by nishudeshu

Loading

int threadpool_open(THANDLE(THREADPOOL) threadpool)

Maybe add a comment saying that the open and close will go away soon. #Resolved

Refers to: linux/src/threadpool_linux.c:446 in a679d72. [](commit_id = a679d72, deletion_comment = False)

jebrando previously approved these changes

View reviewed changes

Contributor

jebrando left a comment

dcristoloveanu reviewed

View reviewed changes

linux/src/threadpool_linux.c Show resolved Hide resolved


          Adding Sleep(1) for threadpool_long_task_v2 and replacing exclusive l…

efbc324

…ocks with shared

Contributor Author

nishudeshu commented Dec 3, 2024 •

edited

Loading

/azp run #Resolved

azure-pipelines bot commented Dec 3, 2024 •

edited by nishudeshu

Loading

Azure Pipelines successfully started running 1 pipeline(s). #Resolved


          Another fix for the failing tests

c2bd6bd

Contributor Author

nishudeshu commented Dec 3, 2024 •

edited

Loading

/azp run #Resolved

azure-pipelines bot commented Dec 3, 2024 •

edited by nishudeshu

Loading

Azure Pipelines successfully started running 1 pipeline(s). #Resolved


          threadpool_long_task_v2 has exclusive lock and Sleep(1)

Contributor Author

nishudeshu commented Dec 3, 2024 •

edited

Loading

/azp run #Resolved

azure-pipelines bot commented Dec 3, 2024 •

edited by nishudeshu

Loading

Azure Pipelines successfully started running 1 pipeline(s). #Resolved

nishudeshu disabled auto-merge

December 3, 2024 17:56


          Fix for the Threadpool test failures

6a3d867

Contributor Author

nishudeshu commented Dec 3, 2024 •

edited

Loading

/azp run #Resolved

azure-pipelines bot commented Dec 3, 2024 •

edited by nishudeshu

Loading

Azure Pipelines successfully started running 1 pipeline(s). #Resolved

nishudeshu enabled auto-merge (squash)

December 3, 2024 23:05


          Merge branch 'master' into nisdeshmukh/threadpool_open_close_linux

593a498

Contributor Author

nishudeshu commented Dec 3, 2024 •

edited

Loading

/azp run #Resolved

azure-pipelines bot commented Dec 3, 2024 •

edited by nishudeshu

Loading

Azure Pipelines successfully started running 1 pipeline(s). #Resolved

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

9 similar comments

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

azure-pipelines bot commented Dec 4, 2024

No pipelines are associated with this pull request.

jebrando approved these changes

View reviewed changes

Contributor

jebrando left a comment

nishudeshu merged commit 3a5f71c into master

11 checks passed

nishudeshu deleted the nisdeshmukh/threadpool_open_close_linux branch

December 4, 2024 00:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jebrando jebrando approved these changes

anporumb Awaiting requested review from anporumb

avranju Awaiting requested review from avranju

mattdurak Awaiting requested review from mattdurak

darobs Awaiting requested review from darobs

ipg2013 Awaiting requested review from ipg2013

parth21999 Awaiting requested review from parth21999

dcristoloveanu Awaiting requested review from dcristoloveanu

Labels

None yet