Skip to content

Commit

Permalink
[a11y][bugfix] Add Close aria label for spotlight prompt (#5366)
Browse files Browse the repository at this point in the history
* Add Close aria label for spotlight prompt

* Change files

* Update stable api files

* Change files
  • Loading branch information
edwardlee-msft authored Oct 28, 2024
1 parent f063458 commit 36c8f34
Show file tree
Hide file tree
Showing 7 changed files with 30 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "prerelease",
"area": "fix",
"workstream": "A11y",
"comment": "Add Close aria label for spotlight prompt",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "prerelease",
"area": "fix",
"workstream": "a11y",
"comment": "Add Close aria label for spotlight prompt",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
Expand Up @@ -4729,6 +4729,7 @@ export type SpotlightChangedListener = (args: {

// @public
export interface SpotlightPromptStrings {
closeSpotlightPromptButtonLabel: string;
startSpotlightCancelButtonLabel: string;
startSpotlightConfirmButtonLabel: string;
startSpotlightHeading: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4061,6 +4061,7 @@ export type SpotlightChangedListener = (args: {

// @public
export interface SpotlightPromptStrings {
closeSpotlightPromptButtonLabel: string;
startSpotlightCancelButtonLabel: string;
startSpotlightConfirmButtonLabel: string;
startSpotlightHeading: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,4 +139,8 @@ export interface SpotlightPromptStrings {
* Label for button to cancel stopping spotlight on participant(s) in prompt
*/
stopSpotlightCancelButtonLabel: string;
/**
* Label for button to close prompt
*/
closeSpotlightPromptButtonLabel: string;
}
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ const getStartLocalSpotlightWithPromptCallback = (
text: strings.spotlightPrompt.startSpotlightOnSelfText,
confirmButtonLabel: strings.spotlightPrompt.startSpotlightConfirmButtonLabel,
cancelButtonLabel: strings.spotlightPrompt.startSpotlightCancelButtonLabel,
closeButtonLabel: strings.spotlightPrompt.closeSpotlightPromptButtonLabel,
onConfirm: () => {
onStartSpotlight();
setIsPromptOpen(false);
Expand Down Expand Up @@ -129,6 +130,7 @@ const getStartRemoteSpotlightWithPromptCallback = (
text: strings.spotlightPrompt.startSpotlightText,
confirmButtonLabel: strings.spotlightPrompt.startSpotlightConfirmButtonLabel,
cancelButtonLabel: strings.spotlightPrompt.startSpotlightCancelButtonLabel,
closeButtonLabel: strings.spotlightPrompt.closeSpotlightPromptButtonLabel,
onConfirm: () => {
onStartSpotlight(userIds);
setIsPromptOpen(false);
Expand All @@ -155,6 +157,7 @@ const getStopRemoteSpotlightWithPromptCallback = (
text: strings.spotlightPrompt.stopSpotlightText,
confirmButtonLabel: strings.spotlightPrompt.stopSpotlightConfirmButtonLabel,
cancelButtonLabel: strings.spotlightPrompt.stopSpotlightCancelButtonLabel,
closeButtonLabel: strings.spotlightPrompt.closeSpotlightPromptButtonLabel,
onConfirm: () => {
onStopSpotlight(userIds);
setIsPromptOpen(false);
Expand Down Expand Up @@ -203,6 +206,7 @@ const getStopAllSpotlightCallbackWithPromptCallback = (
text: strings.spotlightPrompt.stopAllSpotlightText,
confirmButtonLabel: strings.spotlightPrompt.stopSpotlightConfirmButtonLabel,
cancelButtonLabel: strings.spotlightPrompt.stopSpotlightCancelButtonLabel,
closeButtonLabel: strings.spotlightPrompt.closeSpotlightPromptButtonLabel,
onConfirm: () => {
stopAllSpotlight();
setIsPromptOpen(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@
"stopAllSpotlightText": "The videos will no longer be highlighted for everyone in the meeting.",
"stopSpotlightConfirmButtonLabel": "Stop spotlighting",
"stopSpotlightOnSelfConfirmButtonLabel": "Exit spotlight",
"stopSpotlightCancelButtonLabel": "Cancel"
"stopSpotlightCancelButtonLabel": "Cancel",
"closeSpotlightPromptButtonLabel": "Close"
},
"exitSpotlightButtonLabel": "Exit spotlight",
"exitSpotlightButtonTooltip": "Exit spotlight",
Expand Down

0 comments on commit 36c8f34

Please sign in to comment.