Skip to content

Commit

Permalink
pushing port:sample changes into an internal branch instead of extern…
Browse files Browse the repository at this point in the history
…al (#4361)

* pushing port:sample changes into an internal branch instead of external

* forgot the gitignore file and properly merged in pnpmlock file

* Change files
  • Loading branch information
alkwa-msft authored Apr 10, 2024
1 parent 76a858a commit 89da811
Show file tree
Hide file tree
Showing 49 changed files with 183 additions and 174 deletions.
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -114,3 +114,8 @@ apis/

# To avoid accidental checkin of connection string secrets
samples/Server/appsettings.json

samples/Server/sample-dist/
samples/Calling/sample-dist/
samples/CallWithChat/sample-dist/
samples/Chat/sample-dist/
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "none",
"area": "improvement",
"workstream": "Release Driving Improvements",
"comment": "pushing port:sample changes into an internal branch instead of external",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "none"
}
238 changes: 112 additions & 126 deletions common/config/rush/pnpm-lock.yaml

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion common/config/rush/variants/stable/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions docs/releases/hero-samples.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,15 @@ This section uses [an update to the chat hero sample](https://github.com/Azure-S
- In this monorepository,
```
cd samples/Chat
rushx preprocess:stable-flavor
rushx port-sample
```
- This will generate a `samples/Chat/preprocessed` directory which contains the sources from `samples/Chat/src`, but conditionally compiled for the `stable` build flavor and prettified.
- This will generate a `samples/Chat/sample-dist` directory which contains the updates to src, Media, public directories in `samples/Chat/`, but conditionally compiled for the `stable` build flavor and prettified.
- Replace the hero sample sources.
- Create a new branch in the chat hero sample repo.
- Replace `Chat/src` with the generated `samples/Chat/preprocessed` from the last step.
- Replace `Chat/src` with the generated `samples/Chat/sample-dist/src` from the directory we generated in the previous step.
- Replace `Chat/Media` with the generated `samples/Chat/sample-dist/Media` from the directory we generated in the previous step.
- Replace `Chat/public` with the generated `samples/Chat/sample-dist/public` from the directory we generated in the previous step.
- Create a draft Pull Request against `main`.
- Link to the source git commit in upstream that you generated the sources from. [Example PR description](https://github.com/Azure-Samples/communication-services-web-chat-hero/pull/69).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "الصفحة السابقة",
"rightNavButtonAriaLabel": "الصفحة التالية"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "předchozí stránka",
"rightNavButtonAriaLabel": "další stránka"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "Vorherige Seite",
"rightNavButtonAriaLabel": "Nächste Seite"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "previous page",
"rightNavButtonAriaLabel": "next page"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "página anterior",
"rightNavButtonAriaLabel": "página siguiente"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "edellinen sivu",
"rightNavButtonAriaLabel": "seuraava sivu"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "page précédente",
"rightNavButtonAriaLabel": "page suivante"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "הדף הקודם",
"rightNavButtonAriaLabel": "הדף הבא"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "Pagina precedente",
"rightNavButtonAriaLabel": "Pagina successiva"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "前のページ",
"rightNavButtonAriaLabel": "次のページ"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "이전 페이지",
"rightNavButtonAriaLabel": "다음 페이지"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "forrige side",
"rightNavButtonAriaLabel": "neste side"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "vorige pagina",
"rightNavButtonAriaLabel": "volgende pagina"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "poprzednia strona",
"rightNavButtonAriaLabel": "następna strona"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "página anterior",
"rightNavButtonAriaLabel": "próxima página"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "предыдущая страница",
"rightNavButtonAriaLabel": "следующая страница"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "föregående sida",
"rightNavButtonAriaLabel": "nästa sida"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "önceki sayfa",
"rightNavButtonAriaLabel": "sonraki sayfa"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "上一页",
"rightNavButtonAriaLabel": "下一页"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -393,4 +393,4 @@
"leftNavButtonAriaLabel": "上一頁",
"rightNavButtonAriaLabel": "下一頁"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "عرض لوحة الطلب",
"dtmfDialpadPlaceholderText": "أدخل عدداً"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Zobrazit číselník",
"dtmfDialpadPlaceholderText": "Zadejte číslo"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Wähltastatur anzeigen",
"dtmfDialpadPlaceholderText": "Nummer eingeben"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Show dialpad",
"dtmfDialpadPlaceholderText": "Enter number"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Mostrar teclado de marcado",
"dtmfDialpadPlaceholderText": "Introducir número"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Näytä valintapaneeli",
"dtmfDialpadPlaceholderText": "Syötä numero"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Afficher le pavé numérique",
"dtmfDialpadPlaceholderText": "Saisir un numéro"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "הצג לוח חיוג",
"dtmfDialpadPlaceholderText": "הזן מספר"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Mostra tastiera",
"dtmfDialpadPlaceholderText": "Immetti il numero"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "ダイヤルパッドを表示",
"dtmfDialpadPlaceholderText": "番号を入力してください"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "다이얼패드 표시",
"dtmfDialpadPlaceholderText": "번호 입력"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Vis numerisk tastatur",
"dtmfDialpadPlaceholderText": "Skriv inn nummer"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Toetsenblok weergeven",
"dtmfDialpadPlaceholderText": "Nummer invoeren"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Pokaż klawiaturę numeryczną",
"dtmfDialpadPlaceholderText": "Wprowadź numer"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Mostrar teclado de discagem",
"dtmfDialpadPlaceholderText": "Digite o número"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Показать панель набора номера",
"dtmfDialpadPlaceholderText": "Введите номер"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Visa knappsats",
"dtmfDialpadPlaceholderText": "Ange nummer"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "Tuş takımını göster",
"dtmfDialpadPlaceholderText": "Numara girin"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "显示拨号盘",
"dtmfDialpadPlaceholderText": "输入号码"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -375,4 +375,4 @@
"openDtmfDialpadLabel": "顯示撥號盤",
"dtmfDialpadPlaceholderText": "輸入號碼"
}
}
}
3 changes: 2 additions & 1 deletion samples/CallWithChat/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"test": "",
"test:ci-coverage": "echo skip",
"test:stable": "echo skip",
"port:sample": "rushx preprocess:stable-flavor && cpx \"./preprocessed/**\" sample-dist/src && cpx \"./Media/**\" sample-dist/Media && cpx \"./public/**\" sample-dist/public",
"preprocess": "cpx \"./src/**\" ./preprocessed && babel ./src --out-dir ../preprocessed --extensions \".ts,.tsx\" --keep-file-extension --config-file ./.babelrc.js --relative",
"preprocess:stable-flavor": "rushx _stable-flavor \"rushx preprocess && rushx lint:fix && rushx prettier\"",
"prettier": "prettier --no-error-on-unmatched-pattern --write --config ../../.prettierrc --ignore-path=../../.prettierignore \"**/*.js\" \"**/*.jsx\" \"**/*.ts\" \"**/*.tsx\"",
Expand Down Expand Up @@ -73,6 +74,7 @@
"babel-loader": "8.1.0",
"concurrently": "^5.3.0",
"copyfiles": "^2.4.1",
"cpx": "^1.5.0",
"cross-env": "^7.0.3",
"css-loader": "^4.3.0",
"env-cmd": "^10.1.0",
Expand Down Expand Up @@ -103,7 +105,6 @@
"webpack-cli": "^5.1.4",
"webpack-dev-server": "4.15.1",
"webpack-bundle-analyzer": "^4.5.0",
"cpx": "^1.5.0",
"@babel/cli": "^7.23.9"
}
}
5 changes: 3 additions & 2 deletions samples/Calling/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"start:prod": "node dist/server.js",
"test": "",
"test:ci-coverage": "echo skip",
"port:sample": "rushx preprocess:stable-flavor && cpx \"./preprocessed/**\" sample-dist/src && cpx \"./Media/**\" sample-dist/Media && cpx \"./public/**\" sample-dist/public",
"preprocess": "cpx \"./src/**\" ./preprocessed && babel ./src --out-dir ../preprocessed --extensions \".ts,.tsx\" --keep-file-extension --config-file ./.babelrc.js --relative",
"preprocess:stable-flavor": "rushx _stable-flavor \"rushx preprocess && rushx lint:fix && rushx prettier\"",
"prettier": "prettier --no-error-on-unmatched-pattern --write --config ../../.prettierrc --ignore-path=../../.prettierignore \"**/*.js\" \"**/*.jsx\" \"**/*.ts\" \"**/*.tsx\"",
Expand Down Expand Up @@ -74,6 +75,7 @@
"babel-loader": "8.1.0",
"concurrently": "^5.3.0",
"copyfiles": "^2.4.1",
"cpx": "^1.5.0",
"css-loader": "^4.3.0",
"env-cmd": "^10.1.0",
"eslint-config-prettier": "^6.12.0",
Expand Down Expand Up @@ -102,7 +104,6 @@
"webpack-cli": "^5.1.4",
"webpack-dev-server": "4.15.1",
"webpack": "5.89.0",
"webpack-bundle-analyzer": "^4.5.0",
"cpx": "^1.5.0"
"webpack-bundle-analyzer": "^4.5.0"
}
}
Loading

0 comments on commit 89da811

Please sign in to comment.