Skip to content

Commit

Permalink
String change for loading chat in breakout room (#5630)
Browse files Browse the repository at this point in the history
* Change text to loading chat spinner

* Change files

* cc code comment also
  • Loading branch information
mgamis-msft authored Feb 7, 2025
1 parent c118cfd commit 9ab59fc
Show file tree
Hide file tree
Showing 5 changed files with 50 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "feature",
"workstream": "Breakout rooms",
"comment": "Change spinner text when loading chat in breakout room",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "feature",
"workstream": "Breakout rooms",
"comment": "Change spinner text when loading chat in breakout room",
"packageName": "@azure/communication-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/calling-stateful-client/src/CallSubscriber.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ export class CallSubscriber {
this._call.feature(Features.Spotlight)
);

/* @conditional-compile-remove(breakout-rooms) */
// Clear assigned breakout room closed notification for this call.
this._context.deleteLatestNotification('assignedBreakoutRoomClosed');
/* @conditional-compile-remove(breakout-rooms) */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,6 @@ const MainScreen = (props: MainScreenProps): JSX.Element => {
);
break;
case 'call':
case 'returningFromBreakoutRoom':
pageElement = (
<CallPage
callInvitationURL={callInvitationUrl}
Expand Down Expand Up @@ -751,6 +750,36 @@ const MainScreen = (props: MainScreenProps): JSX.Element => {
break;
}

/* @conditional-compile-remove(breakout-rooms) */
if (page === 'returningFromBreakoutRoom') {
pageElement = (
<CallPage
callInvitationURL={callInvitationUrl}
onFetchAvatarPersonaData={onFetchAvatarPersonaData}
onFetchParticipantMenuItems={onFetchParticipantMenuItems}
mobileView={props.mobileView}
modalLayerHostId={props.modalLayerHostId}
options={props.options}
updateSidePaneRenderer={setSidePaneRenderer}
mobileChatTabHeader={props.mobileChatTabHeader}
onCloseChatPane={props.onCloseChatPane}
latestErrors={latestInCallErrors}
latestNotifications={latestNotifications}
onDismissError={onDismissError}
onDismissNotification={onDismissNotification}
galleryLayout={userSetGalleryLayout}
onUserSetGalleryLayoutChange={setUserSetGalleryLayout}
onSetUserSetOverflowGalleryPosition={setUserSetOverflowGalleryPosition}
userSetOverflowGalleryPosition={userSetOverflowGalleryPosition}
capabilitiesChangedNotificationBarProps={capabilitiesChangedNotificationBarProps}
pinnedParticipants={pinnedParticipants}
setPinnedParticipants={setPinnedParticipants}
compositeAudioContext={compositeAudioContext}
disableAutoShowDtmfDialer={props.options?.disableAutoShowDtmfDialer}
/>
);
}

useEndedCallConsoleErrors(endedCall);

/* @conditional-compile-remove(unsupported-browser) */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,6 @@
"openDtmfDialpadLabel": "Show dialpad",
"dtmfDialpadPlaceholderText": "Enter number",
"breakoutRoomChatPaneTitle": "Breakout Room Chat",
"chatContentSpinnerLabel": "Loading..."
"chatContentSpinnerLabel": "Loading chat"
}
}

0 comments on commit 9ab59fc

Please sign in to comment.